From 475f1926528c43b29fed62e13d84e33d98a63496 Mon Sep 17 00:00:00 2001 From: Eoghan McIlwaine Date: Mon, 24 Jan 2022 16:27:12 +0100 Subject: [PATCH 1/6] Replace deprecated component on docs page Signed-off-by: Eoghan McIlwaine --- docs/plugins/integrating-plugin-into-software-catalog.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/plugins/integrating-plugin-into-software-catalog.md b/docs/plugins/integrating-plugin-into-software-catalog.md index 71430e25a0..97efa56ac3 100644 --- a/docs/plugins/integrating-plugin-into-software-catalog.md +++ b/docs/plugins/integrating-plugin-into-software-catalog.md @@ -107,7 +107,7 @@ const systemPage = ( - + {/* Adding a new tab to the system view */} From e7dd277232d2417e687b003c6a1e204a9e32dead Mon Sep 17 00:00:00 2001 From: Eoghan McIlwaine Date: Mon, 24 Jan 2022 16:29:24 +0100 Subject: [PATCH 2/6] Remove EntitySystemDiagramCard code Signed-off-by: Eoghan McIlwaine --- plugins/catalog/src/index.ts | 1 - plugins/catalog/src/plugin.ts | 14 -------------- 2 files changed, 15 deletions(-) diff --git a/plugins/catalog/src/index.ts b/plugins/catalog/src/index.ts index 57dd911b2d..abe34c29b9 100644 --- a/plugins/catalog/src/index.ts +++ b/plugins/catalog/src/index.ts @@ -49,7 +49,6 @@ export { EntityHasSubcomponentsCard, EntityHasSystemsCard, EntityLinksCard, - EntitySystemDiagramCard, RelatedEntitiesCard, } from './plugin'; diff --git a/plugins/catalog/src/plugin.ts b/plugins/catalog/src/plugin.ts index 5a94cd2a09..2e4ebe9570 100644 --- a/plugins/catalog/src/plugin.ts +++ b/plugins/catalog/src/plugin.ts @@ -177,20 +177,6 @@ export const EntityDependsOnResourcesCard = catalogPlugin.provide( }), ); -/** - * @deprecated This component is replaced by EntityCatalogGraphCard which is imported from `@backstage/plugin-catalog-graph`. This component will be removed in an - * upcoming release - */ -export const EntitySystemDiagramCard = catalogPlugin.provide( - createComponentExtension({ - name: 'EntitySystemDiagramCard', - component: { - lazy: () => - import('./components/SystemDiagramCard').then(m => m.SystemDiagramCard), - }, - }), -); - export const RelatedEntitiesCard = catalogPlugin.provide( createComponentExtension({ name: 'RelatedEntitiesCard', From cbe4ab0d204149ac4e6d0019d0a931c81d6b6412 Mon Sep 17 00:00:00 2001 From: Eoghan McIlwaine Date: Mon, 24 Jan 2022 16:33:21 +0100 Subject: [PATCH 3/6] Remove EntitySystemDiagramCard from api report Signed-off-by: Eoghan McIlwaine --- plugins/catalog/api-report.md | 6 ------ 1 file changed, 6 deletions(-) diff --git a/plugins/catalog/api-report.md b/plugins/catalog/api-report.md index ad391b594f..bc29d9ee14 100644 --- a/plugins/catalog/api-report.md +++ b/plugins/catalog/api-report.md @@ -388,12 +388,6 @@ export const EntitySwitch: { }) => null; }; -// Warning: (ae-forgotten-export) The symbol "SystemDiagramCard" needs to be exported by the entry point index.d.ts -// Warning: (ae-missing-release-tag) "EntitySystemDiagramCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) -// -// @public @deprecated (undocumented) -export const EntitySystemDiagramCard: SystemDiagramCard; - // Warning: (ae-missing-release-tag) "FilterContainer" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) // // @public (undocumented) From 37092662cb39757d1ad0c1c7aa1c0d24096e3689 Mon Sep 17 00:00:00 2001 From: Eoghan McIlwaine Date: Mon, 24 Jan 2022 16:56:35 +0100 Subject: [PATCH 4/6] Add changeset for the code removal Signed-off-by: Eoghan McIlwaine --- .changeset/pink-onions-ring.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/pink-onions-ring.md diff --git a/.changeset/pink-onions-ring.md b/.changeset/pink-onions-ring.md new file mode 100644 index 0000000000..c7131721f5 --- /dev/null +++ b/.changeset/pink-onions-ring.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-catalog': minor +--- + +**BREAKING** Completely removed the `EntitySystemDiagramCard` component which was previously deprecated. `EntityCatalogGraphCard` should be used instead, as references to `EntitySystemDiagramCard` will now break. From 76b74230bb9869228885db503a7f6caf9e21fb40 Mon Sep 17 00:00:00 2001 From: Eoghan McIlwaine Date: Mon, 24 Jan 2022 18:34:28 +0100 Subject: [PATCH 5/6] Updated changeset after review comment Signed-off-by: Eoghan McIlwaine --- .changeset/pink-onions-ring.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/pink-onions-ring.md b/.changeset/pink-onions-ring.md index c7131721f5..9ab8f1ae11 100644 --- a/.changeset/pink-onions-ring.md +++ b/.changeset/pink-onions-ring.md @@ -2,4 +2,4 @@ '@backstage/plugin-catalog': minor --- -**BREAKING** Completely removed the `EntitySystemDiagramCard` component which was previously deprecated. `EntityCatalogGraphCard` should be used instead, as references to `EntitySystemDiagramCard` will now break. +**BREAKING** Completely removed the `EntitySystemDiagramCard` component which was deprecated in a previous release. Any remaining references to this component are now broken and should be replaced with `EntityCatalogGraphCard`, which can be imported from package `@backstage/plugin-catalog-graph`. \ No newline at end of file From 973229906208d9c0e9bbb03c9ee83edecc211fab Mon Sep 17 00:00:00 2001 From: Eoghan McIlwaine Date: Tue, 25 Jan 2022 09:58:13 +0100 Subject: [PATCH 6/6] Run prettier on changeset Signed-off-by: Eoghan McIlwaine --- .changeset/pink-onions-ring.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/pink-onions-ring.md b/.changeset/pink-onions-ring.md index 9ab8f1ae11..2b81ad4b43 100644 --- a/.changeset/pink-onions-ring.md +++ b/.changeset/pink-onions-ring.md @@ -2,4 +2,4 @@ '@backstage/plugin-catalog': minor --- -**BREAKING** Completely removed the `EntitySystemDiagramCard` component which was deprecated in a previous release. Any remaining references to this component are now broken and should be replaced with `EntityCatalogGraphCard`, which can be imported from package `@backstage/plugin-catalog-graph`. \ No newline at end of file +**BREAKING** Completely removed the `EntitySystemDiagramCard` component which was deprecated in a previous release. Any remaining references to this component are now broken and should be replaced with `EntityCatalogGraphCard`, which can be imported from package `@backstage/plugin-catalog-graph`.