From e8c521d11173bffb9378c8404fb8e5e3ea8865a0 Mon Sep 17 00:00:00 2001 From: Ivan Shmidt Date: Tue, 19 May 2020 14:21:43 +0200 Subject: [PATCH] fix: type exports --- .../circleci/src/pages/BuildsPage/lib/CITable/index.ts | 3 ++- plugins/circleci/src/state/useBuilds.ts | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/plugins/circleci/src/pages/BuildsPage/lib/CITable/index.ts b/plugins/circleci/src/pages/BuildsPage/lib/CITable/index.ts index 600d6d689f..358939e69f 100644 --- a/plugins/circleci/src/pages/BuildsPage/lib/CITable/index.ts +++ b/plugins/circleci/src/pages/BuildsPage/lib/CITable/index.ts @@ -13,4 +13,5 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -export { CITable, CITableBuildInfo } from './CITable'; +export { CITable } from './CITable'; +export type { CITableBuildInfo } from './CITable'; diff --git a/plugins/circleci/src/state/useBuilds.ts b/plugins/circleci/src/state/useBuilds.ts index 248cc677f6..f90311b56b 100644 --- a/plugins/circleci/src/state/useBuilds.ts +++ b/plugins/circleci/src/state/useBuilds.ts @@ -18,7 +18,7 @@ import { BuildSummary, GitType } from 'circleci-api'; import { useCallback, useEffect, useState } from 'react'; import { useAsyncRetry } from 'react-use'; import { circleCIApiRef } from '../api/index'; -import { CITableBuildInfo } from '../pages/BuildsPage/lib/CITable'; +import type { CITableBuildInfo } from '../pages/BuildsPage/lib/CITable'; import { useSettings } from './useSettings'; const makeReadableStatus = (status: string | undefined) => { @@ -44,7 +44,7 @@ export const transform = ( buildsData: BuildSummary[], restartBuild: { (buildId: number): Promise }, ): CITableBuildInfo[] => { - return buildsData.map((buildData) => { + return buildsData.map(buildData => { const tableBuildInfo: CITableBuildInfo = { id: String(buildData.build_num), buildName: buildData.subject @@ -120,7 +120,7 @@ export function useBuilds() { }; useEffect(() => { - getBuilds({ limit: 1, offset: 0 }).then((b) => setTotal(b?.[0].build_num!)); + getBuilds({ limit: 1, offset: 0 }).then(b => setTotal(b?.[0].build_num!)); }, [repo]); const { loading, value, retry } = useAsyncRetry( @@ -128,7 +128,7 @@ export function useBuilds() { getBuilds({ offset: page * pageSize, limit: pageSize, - }).then((builds) => transform(builds ?? [], restartBuild)), + }).then(builds => transform(builds ?? [], restartBuild)), [page, pageSize, getBuilds], );