From 8b800caaf93f96649777b89b6b5c1142b82b81bc Mon Sep 17 00:00:00 2001 From: Oliver Sand Date: Thu, 14 Jan 2021 13:32:09 +0100 Subject: [PATCH 1/2] Removes the @types/hemlet dependency We are using hemlet 4.0.0+ which has tpying included. The typing dependency is not needed anymore. --- packages/backend/package.json | 3 +-- .../default-app/packages/backend/package.json.hbs | 3 +-- yarn.lock | 7 ------- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/packages/backend/package.json b/packages/backend/package.json index 1e6819b7b8..09a4195a96 100644 --- a/packages/backend/package.json +++ b/packages/backend/package.json @@ -56,8 +56,7 @@ "@backstage/cli": "^0.4.3", "@types/dockerode": "^3.2.1", "@types/express": "^4.17.6", - "@types/express-serve-static-core": "^4.17.5", - "@types/helmet": "^0.0.48" + "@types/express-serve-static-core": "^4.17.5" }, "files": [ "dist" diff --git a/packages/create-app/templates/default-app/packages/backend/package.json.hbs b/packages/create-app/templates/default-app/packages/backend/package.json.hbs index 7b7429d838..3fed72f07b 100644 --- a/packages/create-app/templates/default-app/packages/backend/package.json.hbs +++ b/packages/create-app/templates/default-app/packages/backend/package.json.hbs @@ -45,8 +45,7 @@ "@backstage/cli": "^{{version '@backstage/cli'}}", "@types/dockerode": "^3.2.1", "@types/express": "^4.17.6", - "@types/express-serve-static-core": "^4.17.5", - "@types/helmet": "^0.0.47" + "@types/express-serve-static-core": "^4.17.5" }, "files": [ "dist" diff --git a/yarn.lock b/yarn.lock index 88c099a5b5..a58546f126 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6479,13 +6479,6 @@ dependencies: "@types/unist" "*" -"@types/helmet@^0.0.48": - version "0.0.48" - resolved "https://registry.npmjs.org/@types/helmet/-/helmet-0.0.48.tgz#e754399d2f4672ba63962e8490efd3edd31d9799" - integrity sha512-C7MpnvSDrunS1q2Oy1VWCY7CDWHozqSnM8P4tFeRTuzwqni+PYOjEredwcqWG+kLpYcgLsgcY3orHB54gbx2Jw== - dependencies: - "@types/express" "*" - "@types/history@*": version "4.7.5" resolved "https://registry.npmjs.org/@types/history/-/history-4.7.5.tgz#527d20ef68571a4af02ed74350164e7a67544860" From db05f7a35862642905a4ef09bae6fa5a647f732f Mon Sep 17 00:00:00 2001 From: Oliver Sand Date: Thu, 14 Jan 2021 15:29:21 +0100 Subject: [PATCH 2/2] Add changeset --- .changeset/unlucky-cougars-grin.md | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 .changeset/unlucky-cougars-grin.md diff --git a/.changeset/unlucky-cougars-grin.md b/.changeset/unlucky-cougars-grin.md new file mode 100644 index 0000000000..3c48a612e4 --- /dev/null +++ b/.changeset/unlucky-cougars-grin.md @@ -0,0 +1,9 @@ +--- +'@backstage/create-app': patch +--- + +Remove the `@types/helmet` dev dependency from the app template. This +dependency is now unused as the package `helmet` brings its own types. + +To update your existing app, simply remove the `@types/helmet` dependency from +the `package.json` of your backend package.