From e78f083cb2f6a31f3ecc1ae223f987856ea9181c Mon Sep 17 00:00:00 2001 From: Philippe Ballandras Date: Thu, 30 Mar 2023 13:49:13 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Boris Bera Signed-off-by: Philippe Ballandras --- .../scaffolder/actions/builtin/publish/githubPullRequest.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts index 28fe89318b..6706ad9c06 100644 --- a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts +++ b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts @@ -206,7 +206,7 @@ export const createPublishGithubPullRequestAction = ( commitMessage: { type: 'string', title: 'Commit Message', - description: 'The commit message for the PR commit', + description: 'The commit message for the pull request commit', }, }, }, @@ -305,7 +305,7 @@ export const createPublishGithubPullRequestAction = ( changes: [ { files, - commit: commitMessage || title, + commit: commitMessage ?? title, }, ], body: description,