From e65c4896f755799d01e6ef15a606ef7f09ff762e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Wed, 2 Aug 2023 15:17:29 +0200 Subject: [PATCH] Do not throw in backend.stop, if start failed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fredrik Adelöw --- .changeset/brown-taxis-develop.md | 5 +++++ packages/backend-app-api/src/wiring/BackendInitializer.ts | 7 ++++++- 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 .changeset/brown-taxis-develop.md diff --git a/.changeset/brown-taxis-develop.md b/.changeset/brown-taxis-develop.md new file mode 100644 index 0000000000..19ebfdef1a --- /dev/null +++ b/.changeset/brown-taxis-develop.md @@ -0,0 +1,5 @@ +--- +'@backstage/backend-app-api': patch +--- + +Do not throw in backend.stop, if start failed diff --git a/packages/backend-app-api/src/wiring/BackendInitializer.ts b/packages/backend-app-api/src/wiring/BackendInitializer.ts index 8c2b75e887..ec4b2a79ac 100644 --- a/packages/backend-app-api/src/wiring/BackendInitializer.ts +++ b/packages/backend-app-api/src/wiring/BackendInitializer.ts @@ -259,7 +259,12 @@ export class BackendInitializer { if (!this.#startPromise) { return; } - await this.#startPromise; + + try { + await this.#startPromise; + } catch (error) { + // The startup failed, but we may still want to do cleanup so we continue silently + } const lifecycleService = await this.#getRootLifecycleImpl(); await lifecycleService.shutdown();