From e635b61fcb14242fa7fa2c92b9a0b9b7d40aa081 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Fri, 10 Nov 2023 11:19:53 +0100 Subject: [PATCH] fix zip archive flakiness MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fredrik Adelöw --- .../src/reading/tree/ZipArchiveResponse.test.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/backend-common/src/reading/tree/ZipArchiveResponse.test.ts b/packages/backend-common/src/reading/tree/ZipArchiveResponse.test.ts index ccf53e7cff..a80f688436 100644 --- a/packages/backend-common/src/reading/tree/ZipArchiveResponse.test.ts +++ b/packages/backend-common/src/reading/tree/ZipArchiveResponse.test.ts @@ -196,12 +196,14 @@ describe('ZipArchiveResponse', () => { const fileSize = 1000 * 1000; const filePath = await new Promise((resolve, reject) => { const outFile = targetDir.resolve('large-archive.zip'); - const archive = createArchive('zip'); + const outStream = fs.createWriteStream(outFile); + outStream.on('close', () => resolve(outFile)); + + const archive = createArchive('zip'); archive.on('error', reject); - archive.on('end', () => resolve(outFile)); - archive.pipe(fs.createWriteStream(outFile)); archive.on('warning', w => console.warn('WARN', w)); + archive.pipe(outStream); for (let i = 0; i < fileCount; i++) { // Workaround for https://github.com/archiverjs/node-archiver/issues/542