From e50d1990f84d152b415eeea77e7df8754f767281 Mon Sep 17 00:00:00 2001 From: Camila Belo Date: Thu, 9 Nov 2023 10:21:52 +0100 Subject: [PATCH] refactor: simplify ignored links filter Signed-off-by: Camila Belo --- .changeset/backstage-changelog.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.changeset/backstage-changelog.js b/.changeset/backstage-changelog.js index 3425342405..61734f9f67 100644 --- a/.changeset/backstage-changelog.js +++ b/.changeset/backstage-changelog.js @@ -34,17 +34,16 @@ async function getDependencyReleaseLine(changesets, dependenciesUpdated) { async function getReleaseLine(changeset, type, options) { const { ignoreUserThanks: users = [] } = options ?? {}; + const ignoredLinks = new Set( + users.map(user => `[@${user}](https://github.com/${user})`), + ); const releaseLine = await defaultChangelogFunctions.getReleaseLine( changeset, type, options, ); return releaseLine.replace(/Thanks\s(.*)!\s/g, (_, group) => { - const links = group - .split(', ') - .filter(link => - users.every(user => `[@${user}](https://github.com/${user})` !== link), - ); + const links = group.split(', ').filter(link => !ignoredLinks.has(link)); return links.length ? `Thanks ${links.join(', ')}! ` : ''; }); }