From e46754a18b1bcd9e63e3ae6a56b80be3eaf52c7d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= <freben@gmail.com>
Date: Fri, 30 Aug 2024 13:46:40 +0200
Subject: [PATCH] remove the unused dropDatabase in the connector
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
---
 .../src/entrypoints/database/DatabaseManager.test.ts        | 6 ------
 .../src/entrypoints/database/connectors/mysql.ts            | 4 ----
 .../src/entrypoints/database/connectors/postgres.ts         | 4 ----
 .../src/entrypoints/database/connectors/sqlite3.ts          | 4 ----
 packages/backend-defaults/src/entrypoints/database/types.ts | 2 --
 5 files changed, 20 deletions(-)

diff --git a/packages/backend-defaults/src/entrypoints/database/DatabaseManager.test.ts b/packages/backend-defaults/src/entrypoints/database/DatabaseManager.test.ts
index 0d52ff16ff..fca6080329 100644
--- a/packages/backend-defaults/src/entrypoints/database/DatabaseManager.test.ts
+++ b/packages/backend-defaults/src/entrypoints/database/DatabaseManager.test.ts
@@ -26,11 +26,9 @@ describe('DatabaseManagerImpl', () => {
   it('calls the right connector, only once per plugin id', async () => {
     const connector1 = {
       getClient: jest.fn(),
-      dropDatabase: jest.fn(),
     } satisfies Connector;
     const connector2 = {
       getClient: jest.fn(),
-      dropDatabase: jest.fn(),
     } satisfies Connector;
 
     const impl = new DatabaseManagerImpl(
@@ -62,11 +60,9 @@ describe('DatabaseManagerImpl', () => {
   it('respects per-plugin overridden connectors', async () => {
     const connector1 = {
       getClient: jest.fn(),
-      dropDatabase: jest.fn(),
     } satisfies Connector;
     const connector2 = {
       getClient: jest.fn(),
-      dropDatabase: jest.fn(),
     } satisfies Connector;
 
     const impl = new DatabaseManagerImpl(
@@ -99,7 +95,6 @@ describe('DatabaseManagerImpl', () => {
   it('migration skip options take precedence over config', async () => {
     const connector = {
       getClient: jest.fn(),
-      dropDatabase: jest.fn(),
     } satisfies Connector;
 
     const impl = new DatabaseManagerImpl(
@@ -133,7 +128,6 @@ describe('DatabaseManagerImpl', () => {
   it('plugin can skip migrations using config', async () => {
     const connector = {
       getClient: jest.fn(),
-      dropDatabase: jest.fn(),
     } satisfies Connector;
 
     const impl = new DatabaseManagerImpl(
diff --git a/packages/backend-defaults/src/entrypoints/database/connectors/mysql.ts b/packages/backend-defaults/src/entrypoints/database/connectors/mysql.ts
index b11b659a6d..f06db5999d 100644
--- a/packages/backend-defaults/src/entrypoints/database/connectors/mysql.ts
+++ b/packages/backend-defaults/src/entrypoints/database/connectors/mysql.ts
@@ -293,10 +293,6 @@ export class MysqlConnector implements Connector {
     return client;
   }
 
-  async dropDatabase(...databaseNames: string[]): Promise<void> {
-    return await dropMysqlDatabase(this.config, ...databaseNames);
-  }
-
   /**
    * Provides the canonical database name for a given plugin.
    *
diff --git a/packages/backend-defaults/src/entrypoints/database/connectors/postgres.ts b/packages/backend-defaults/src/entrypoints/database/connectors/postgres.ts
index 46b958789d..18418a271a 100644
--- a/packages/backend-defaults/src/entrypoints/database/connectors/postgres.ts
+++ b/packages/backend-defaults/src/entrypoints/database/connectors/postgres.ts
@@ -312,10 +312,6 @@ export class PgConnector implements Connector {
     return client;
   }
 
-  async dropDatabase(...databaseNames: string[]): Promise<void> {
-    return await dropPgDatabase(this.config, ...databaseNames);
-  }
-
   /**
    * Provides the canonical database name for a given plugin.
    *
diff --git a/packages/backend-defaults/src/entrypoints/database/connectors/sqlite3.ts b/packages/backend-defaults/src/entrypoints/database/connectors/sqlite3.ts
index 97ba6d46fd..77e8303390 100644
--- a/packages/backend-defaults/src/entrypoints/database/connectors/sqlite3.ts
+++ b/packages/backend-defaults/src/entrypoints/database/connectors/sqlite3.ts
@@ -210,10 +210,6 @@ export class Sqlite3Connector implements Connector {
     return client;
   }
 
-  async dropDatabase(..._databaseNames: string[]): Promise<void> {
-    // do nothing
-  }
-
   /**
    * Provides the canonical database name for a given plugin.
    *
diff --git a/packages/backend-defaults/src/entrypoints/database/types.ts b/packages/backend-defaults/src/entrypoints/database/types.ts
index 74f41581f6..57b85ff3c1 100644
--- a/packages/backend-defaults/src/entrypoints/database/types.ts
+++ b/packages/backend-defaults/src/entrypoints/database/types.ts
@@ -30,6 +30,4 @@ export interface Connector {
       pluginMetadata: PluginMetadataService;
     },
   ): Promise<Knex>;
-
-  dropDatabase(...databaseNames: string[]): Promise<void>;
 }