Merge pull request #19565 from backstage/rugvip/1820

Switch to Node.js v18 + v20

packages/create-app/package.json

@@ -46,9 +46,9 @@
     "@types/command-exists": "^1.2.0",
     "@types/fs-extra": "^9.0.1",
     "@types/inquirer": "^8.1.3",
-    "@types/node": "^16.11.26",
+    "@types/node": "^18.17.8",
     "@types/recursive-readdir": "^2.2.0",
-    "mock-fs": "^5.1.1",
+    "mock-fs": "^5.2.0",
     "nodemon": "^3.0.1",
     "ts-node": "^10.0.0"
   },

packages/create-app/src/lib/tasks.test.ts

@@ -304,13 +304,13 @@ describe('tasks', () => {
         },
       );
       // catalog was populated with `context.name`
-      expect(
-        fs.readFileSync('templatedApp/catalog-info.yaml', 'utf-8'),
-      ).toContain('name: SuperCoolBackstageInstance');
+      await expect(
+        fs.readFile('templatedApp/catalog-info.yaml', 'utf-8'),
+      ).resolves.toContain('name: SuperCoolBackstageInstance');
       // backend dependencies include `sqlite3` from `context.SQLite`
-      expect(
-        fs.readFileSync('templatedApp/packages/backend/package.json', 'utf-8'),
-      ).toContain('sqlite3"');
+      await expect(
+        fs.readFile('templatedApp/packages/backend/package.json', 'utf-8'),
+      ).resolves.toContain('sqlite3"');
     });
   });
 

packages/create-app/templates/default-app/package.json.hbs

@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "private": true,
   "engines": {
-    "node": "16 || 18"
+    "node": "18 || 20"
   },
   "scripts": {
     "dev": "concurrently \"yarn start\" \"yarn start-backend\"",