paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 23 Packages Projects Releases Wiki Activity

TechDocs: Make requestUrl and storageUrl optional configs by using discovery APIs

Browse Source 
closes #3715

Co-authored-by: Himanshu Mishra <himanshu@orkohunter.net>
This commit is contained in:
Parth Shandilya
2021-01-19 23:46:48 +01:00
committed by Himanshu Mishra
parent 17b87a9305
commit e44925723e
18 changed files with 154 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/techdocs-common/src/stages/publish/local.ts
+13 -4
View File
@@ -23,6 +23,7 @@ import { Entity, EntityName } from '@backstage/catalog-model';
import {
resolvePackagePath,
PluginEndpointDiscovery,
SingleHostDiscovery,
} from '@backstage/backend-common';
import { Config } from '@backstage/config';
import {
@@ -109,9 +110,9 @@ export class LocalPublish implements PublisherBase {
fetchTechDocsMetadata(entityName: EntityName): Promise<TechDocsMetadata> {
return new Promise((resolve, reject) => {
this.discovery.getBaseUrl('techdocs').then(techdocsApiUrl => {
this.discovery.getBaseUrl('techdocs').then(async techdocsApiUrl => {
const storageUrl = new URL(
new URL(this.config.getString('techdocs.storageUrl')).pathname,
new URL(await this.getStorageUrl()).pathname,
techdocsApiUrl,
).toString();
@@ -141,12 +142,20 @@ export class LocalPublish implements PublisherBase {
return express.static(staticDocsDir);
}
async getStorageUrl() {
const discoveryApi = SingleHostDiscovery.fromConfig(this.config);
return (
this.config.getOptionalString('techdocs.storageUrl') ??
(await discoveryApi.getBaseUrl('techdocs'))
);
}
async hasDocsBeenGenerated(entity: Entity): Promise<boolean> {
const namespace = entity.metadata.namespace ?? 'default';
return new Promise(resolve => {
this.discovery.getBaseUrl('techdocs').then(techdocsApiUrl => {
this.discovery.getBaseUrl('techdocs').then(async techdocsApiUrl => {
const storageUrl = new URL(
new URL(this.config.getString('techdocs.storageUrl')).pathname,
new URL(await this.getStorageUrl()).pathname,
techdocsApiUrl,
).toString();