From e36176020266519cc57fa2f00a779000a9c2e3c1 Mon Sep 17 00:00:00 2001 From: Johan Haals Date: Fri, 13 May 2022 09:37:54 +0200 Subject: [PATCH] simplify exclude list filtering Signed-off-by: Johan Haals --- scripts/prepare-release.js | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/scripts/prepare-release.js b/scripts/prepare-release.js index fdf76f0a90..e4c987733d 100755 --- a/scripts/prepare-release.js +++ b/scripts/prepare-release.js @@ -351,22 +351,23 @@ async function ensureCreateAppChangeset() { }), ); - let excludeList = []; + const excludeList = []; const prePath = path.resolve(changesetPath, 'pre.json'); if (await fs.pathExists(prePath)) { const data = await fs.readJSON(prePath); // Only exclude changesets in pre-release mode. - excludeList = - data.mode === 'pre' ? data.changesets.map(name => `${name}.md`) : []; + if (data.mode === 'pre') { + excludeList.push(...data.changesets.map(name => `${name}.md`)); + } } + const hasCreateAppChanges = changesets .filter(({ name }) => !excludeList.includes(name)) - .map(changeset => + .some(changeset => changeset.releases.some( release => release.name === '@backstage/create-app', ), - ) - .includes(true); + ); if (hasCreateAppChanges) { console.log(