From e290590517a7141102b4e7a4f325ceb7d871ef59 Mon Sep 17 00:00:00 2001 From: Andre Wanlin Date: Fri, 8 Oct 2021 11:11:10 -0500 Subject: [PATCH] Applied suggested async and await changes Signed-off-by: Andre Wanlin --- packages/backend/src/plugins/azure-devops.ts | 4 ++-- plugins/azure-devops/README.md | 4 ++-- plugins/azure-devops/src/api/AzureDevOpsClient.ts | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/backend/src/plugins/azure-devops.ts b/packages/backend/src/plugins/azure-devops.ts index e11a21ba2e..4120e655ed 100644 --- a/packages/backend/src/plugins/azure-devops.ts +++ b/packages/backend/src/plugins/azure-devops.ts @@ -18,9 +18,9 @@ import { createRouter } from '@backstage/plugin-azure-devops-backend'; import { Router } from 'express'; import type { PluginEnvironment } from '../types'; -export default async function createPlugin({ +export default function createPlugin({ logger, config, }: PluginEnvironment): Promise { - return await createRouter({ logger, config }); + return createRouter({ logger, config }); } diff --git a/plugins/azure-devops/README.md b/plugins/azure-devops/README.md index d2ab1b6c6f..8b25800bb7 100644 --- a/plugins/azure-devops/README.md +++ b/plugins/azure-devops/README.md @@ -48,11 +48,11 @@ Here's how to get the backend up and running: import { Router } from 'express'; import type { PluginEnvironment } from '../types'; - export default async function createPlugin({ + export default function createPlugin({ logger, config, }: PluginEnvironment): Promise { - return await createRouter({ logger, config }); + return createRouter({ logger, config }); } ``` diff --git a/plugins/azure-devops/src/api/AzureDevOpsClient.ts b/plugins/azure-devops/src/api/AzureDevOpsClient.ts index d82dfbe09e..02cac3b9de 100644 --- a/plugins/azure-devops/src/api/AzureDevOpsClient.ts +++ b/plugins/azure-devops/src/api/AzureDevOpsClient.ts @@ -31,12 +31,12 @@ export class AzureDevOpsClient implements AzureDevOpsApi { this.identityApi = options.identityApi; } - async getRepoBuilds( + getRepoBuilds( projectName: string, repoName: string, top: number, ): Promise { - return await this.get(`repo-builds/${projectName}/${repoName}?top=${top}`); + return this.get(`repo-builds/${projectName}/${repoName}?top=${top}`); } private async get(path: string): Promise { @@ -53,6 +53,6 @@ export class AzureDevOpsClient implements AzureDevOpsApi { throw new AzureDevOpsClientError(response, payload); } - return await response.json(); + return response.json() as Promise; } }