From e203b23433146de6df0bb9de41214675e355b0e1 Mon Sep 17 00:00:00 2001
From: Camila Belo <camilaibs@gmail.com>
Date: Mon, 25 Nov 2024 14:53:32 +0100
Subject: [PATCH] refactor: use zero for empty response content length

Signed-off-by: Camila Belo <camilaibs@gmail.com>
---
 .../rootHttpRouter/http/MiddlewareFactory.test.ts           | 6 +++---
 .../entrypoints/rootHttpRouter/http/MiddlewareFactory.ts    | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/packages/backend-defaults/src/entrypoints/rootHttpRouter/http/MiddlewareFactory.test.ts b/packages/backend-defaults/src/entrypoints/rootHttpRouter/http/MiddlewareFactory.test.ts
index f5256f5a25..1c140791b6 100644
--- a/packages/backend-defaults/src/entrypoints/rootHttpRouter/http/MiddlewareFactory.test.ts
+++ b/packages/backend-defaults/src/entrypoints/rootHttpRouter/http/MiddlewareFactory.test.ts
@@ -245,13 +245,13 @@ describe('MiddlewareFactory', () => {
     it('should log incoming requests', async () => {
       const app = express();
       app.use(middleware.logging());
-      app.get('/', (_req, res) => res.send('Hello World'));
+      app.get('/', (_req, res) => res.send(''));
 
       await request(app).get('/').expect(200);
 
       expect(logger.info).toHaveBeenCalledWith(
         expect.stringContaining(
-          '[2024-11-20T00:00:00.000Z] "GET / HTTP/1.1" 200 11 "-" "-"',
+          '[2024-11-20T00:00:00.000Z] "GET / HTTP/1.1" 200 0 "-" "-"',
         ),
         {
           type: 'incomingRequest',
@@ -260,7 +260,7 @@ describe('MiddlewareFactory', () => {
           url: '/',
           status: 200,
           httpVersion: '1.1',
-          contentLength: 11,
+          contentLength: 0,
         },
       );
     });
diff --git a/packages/backend-defaults/src/entrypoints/rootHttpRouter/http/MiddlewareFactory.ts b/packages/backend-defaults/src/entrypoints/rootHttpRouter/http/MiddlewareFactory.ts
index a22b783f24..1ff9bd15d1 100644
--- a/packages/backend-defaults/src/entrypoints/rootHttpRouter/http/MiddlewareFactory.ts
+++ b/packages/backend-defaults/src/entrypoints/rootHttpRouter/http/MiddlewareFactory.ts
@@ -182,9 +182,9 @@ export class MiddlewareFactory {
         logger.info(
           `[${meta.date}] "${meta.method} ${meta.url} HTTP/${
             meta.httpVersion
-          }" ${meta.status} ${meta.contentLength} "${meta.referrer ?? '-'}" "${
-            meta.userAgent ?? '-'
-          }"`,
+          }" ${meta.status} ${meta.contentLength ?? 0} "${
+            meta.referrer ?? '-'
+          }" "${meta.userAgent ?? '-'}"`,
           {
             type: 'incomingRequest',
             ...meta,