From e4f7bf5a57bcdac8cce9b7bca0b1fca947e5a773 Mon Sep 17 00:00:00 2001 From: Anton Ganhammar Date: Sat, 2 Sep 2023 08:01:31 +0200 Subject: [PATCH 1/3] fix: add text body parser Signed-off-by: Anton Ganhammar --- plugins/code-coverage-backend/src/service/router.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/code-coverage-backend/src/service/router.ts b/plugins/code-coverage-backend/src/service/router.ts index 06a108dd0e..3b97f2d233 100644 --- a/plugins/code-coverage-backend/src/service/router.ts +++ b/plugins/code-coverage-backend/src/service/router.ts @@ -67,6 +67,7 @@ export const makeRouter = async ( bodyParserXml(BodyParser); const router = Router(); router.use(BodyParser.xml()); + router.use(BodyParser.text()); router.use(express.json()); const utils = new CoverageUtils(scm, urlReader); From df005d9932fbb981af621d21581fd97a7feda6eb Mon Sep 17 00:00:00 2001 From: Anton Ganhammar Date: Sat, 2 Sep 2023 08:05:04 +0200 Subject: [PATCH 2/3] chore: add changeset Signed-off-by: Anton Ganhammar --- .changeset/late-roses-dream.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/late-roses-dream.md diff --git a/.changeset/late-roses-dream.md b/.changeset/late-roses-dream.md new file mode 100644 index 0000000000..b0c2316c95 --- /dev/null +++ b/.changeset/late-roses-dream.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-code-coverage-backend': patch +--- + +Add text body parser for LCOV reports From 7e9ed3a58edbdcc7b33579c0e45880d1d2c7f5d7 Mon Sep 17 00:00:00 2001 From: Anton Ganhammar Date: Sat, 2 Sep 2023 08:24:53 +0200 Subject: [PATCH 3/3] fix: if scm only is false, the file should still be included Signed-off-by: Anton Ganhammar --- plugins/code-coverage-backend/src/service/converter/lcov.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/code-coverage-backend/src/service/converter/lcov.ts b/plugins/code-coverage-backend/src/service/converter/lcov.ts index beaa574075..e2f5733dae 100644 --- a/plugins/code-coverage-backend/src/service/converter/lcov.ts +++ b/plugins/code-coverage-backend/src/service/converter/lcov.ts @@ -75,9 +75,9 @@ export class Lcov implements Converter { this.logger.debug(`matched ${file} to ${filename}`); - if (filename) { + if (scmFiles.length === 0 || filename) { return { - filename, + filename: filename || file, lineHits: {}, branchHits: {}, };