From e1d3fcf1c016321ea1e4c3f966870cf17340df4d Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 11 Mar 2021 17:50:29 +0100 Subject: [PATCH] todo-backend: review suggestions Signed-off-by: Patrik Oldsberg --- packages/app/package.json | 2 +- plugins/todo-backend/package.json | 2 +- plugins/todo-backend/src/service/TodoReaderService.ts | 2 -- plugins/todo-backend/src/service/router.test.ts | 2 +- plugins/todo/package.json | 2 +- 5 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/app/package.json b/packages/app/package.json index 7925c203e3..3d9f83d89f 100644 --- a/packages/app/package.json +++ b/packages/app/package.json @@ -33,7 +33,7 @@ "@backstage/plugin-search": "^0.3.3", "@backstage/plugin-tech-radar": "^0.3.7", "@backstage/plugin-techdocs": "^0.6.1", - "@backstage/plugin-todo": "^0.1.1", + "@backstage/plugin-todo": "^0.1.0", "@backstage/plugin-user-settings": "^0.2.7", "@backstage/theme": "^0.2.4", "@material-ui/core": "^4.11.0", diff --git a/plugins/todo-backend/package.json b/plugins/todo-backend/package.json index 58d335732b..888c9a404c 100644 --- a/plugins/todo-backend/package.json +++ b/plugins/todo-backend/package.json @@ -1,6 +1,6 @@ { "name": "@backstage/plugin-todo-backend", - "version": "0.1.1", + "version": "0.1.0", "main": "src/index.ts", "types": "src/index.ts", "license": "Apache-2.0", diff --git a/plugins/todo-backend/src/service/TodoReaderService.ts b/plugins/todo-backend/src/service/TodoReaderService.ts index 3965257eff..bc8ebbcd22 100644 --- a/plugins/todo-backend/src/service/TodoReaderService.ts +++ b/plugins/todo-backend/src/service/TodoReaderService.ts @@ -74,8 +74,6 @@ export class TodoReaderService implements TodoService { let offset = req.offset ?? 0; if (offset < 0) { offset = 0; - } else if (offset - limit > totalCount) { - offset = totalCount - limit; } let items = todos.items; diff --git a/plugins/todo-backend/src/service/router.test.ts b/plugins/todo-backend/src/service/router.test.ts index 1bd70c1643..3c17176dab 100644 --- a/plugins/todo-backend/src/service/router.test.ts +++ b/plugins/todo-backend/src/service/router.test.ts @@ -44,7 +44,7 @@ describe('createRouter', () => { jest.resetAllMocks(); }); - describe('GET /health', () => { + describe('GET /todos', () => { it('returns list without query', async () => { mockService.listTodos.mockResolvedValueOnce(mockListBody); diff --git a/plugins/todo/package.json b/plugins/todo/package.json index ee105287f5..d940dfbe8a 100644 --- a/plugins/todo/package.json +++ b/plugins/todo/package.json @@ -1,6 +1,6 @@ { "name": "@backstage/plugin-todo", - "version": "0.1.1", + "version": "0.1.0", "main": "src/index.ts", "types": "src/index.ts", "license": "Apache-2.0",