From e14ad7c018e43b6e78d32860bf3bd6c87342dead Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 7 Aug 2023 11:16:25 +0200 Subject: [PATCH] auth-node: fix OAuth redirect flow return Signed-off-by: Patrik Oldsberg --- plugins/auth-node/src/oauth/createOAuthRouteHandlers.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/plugins/auth-node/src/oauth/createOAuthRouteHandlers.ts b/plugins/auth-node/src/oauth/createOAuthRouteHandlers.ts index fa6cb57e31..72640c8692 100644 --- a/plugins/auth-node/src/oauth/createOAuthRouteHandlers.ts +++ b/plugins/auth-node/src/oauth/createOAuthRouteHandlers.ts @@ -241,9 +241,11 @@ export function createOAuthRouteHandlers( ); } res.redirect(state.redirectUrl); + return; } + // post message back to popup if successful - return sendWebMessageResponse(res, appOrigin, { + sendWebMessageResponse(res, appOrigin, { type: 'authorization_response', response, }); @@ -252,7 +254,7 @@ export function createOAuthRouteHandlers( ? error : new Error('Encountered invalid error'); // Being a bit safe and not forwarding the bad value // post error message back to popup if failure - return sendWebMessageResponse(res, appOrigin, { + sendWebMessageResponse(res, appOrigin, { type: 'authorization_response', error: { name, message }, });