From e06ebde7f4cf40edd2c8008a6144bf8263c89aa0 Mon Sep 17 00:00:00 2001 From: Johan Haals Date: Thu, 31 Mar 2022 15:01:39 +0200 Subject: [PATCH 1/5] renovate: Set rangeStrategy to update-lockfile Signed-off-by: Johan Haals Signed-off-by: sandra-greenhalgh --- .github/renovate.json5 | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/renovate.json5 b/.github/renovate.json5 index 47b10068cc..aaf292f8cc 100644 --- a/.github/renovate.json5 +++ b/.github/renovate.json5 @@ -1,4 +1,5 @@ { labels: ['dependencies'], extends: ['config:base', ':disableDependencyDashboard', ':gitSignOff'], + rangeStrategy: 'update-lockfile', } From 0a59250f5be54b61bf3206fc4ebd79171bcb4037 Mon Sep 17 00:00:00 2001 From: sandra-greenhalgh Date: Thu, 31 Mar 2022 17:04:09 +0100 Subject: [PATCH 2/5] Add name for BackstageTab styles Signed-off-by: sandra-greenhalgh --- .../src/components/Tabs/Tab.tsx | 35 ++++++++++--------- 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/packages/core-components/src/components/Tabs/Tab.tsx b/packages/core-components/src/components/Tabs/Tab.tsx index 571640d970..4420ac2925 100644 --- a/packages/core-components/src/components/Tabs/Tab.tsx +++ b/packages/core-components/src/components/Tabs/Tab.tsx @@ -37,24 +37,27 @@ const tabMarginLeft = (isFirstNav: boolean, isFirstIndex: boolean) => { return '40px'; }; -const useStyles = makeStyles(theme => ({ - root: { - textTransform: 'none', - height: '64px', - fontWeight: theme.typography.fontWeightBold, - fontSize: theme.typography.pxToRem(13), - color: theme.palette.textSubtle, - marginLeft: props => - tabMarginLeft(props.isFirstNav as boolean, props.isFirstIndex as boolean), - width: '130px', - minWidth: '130px', - '&:hover': { - outline: 'none', - backgroundColor: 'transparent', +const useStyles = makeStyles( + theme => ({ + root: { + textTransform: 'none', + height: '64px', + fontWeight: theme.typography.fontWeightBold, + fontSize: theme.typography.pxToRem(13), color: theme.palette.textSubtle, + marginLeft: props => + tabMarginLeft(props.isFirstNav as boolean, props.isFirstIndex as boolean), + width: '130px', + minWidth: '130px', + '&:hover': { + outline: 'none', + backgroundColor: 'transparent', + color: theme.palette.textSubtle, + }, }, - }, -})); + }), + { name: 'BackstageTab' }, +); export const StyledTab = (props: StyledTabProps) => { const classes = useStyles(props); From a13604b8f7360cfacf7fe90607e721de05bd1bde Mon Sep 17 00:00:00 2001 From: sandra-greenhalgh Date: Thu, 31 Mar 2022 17:17:24 +0100 Subject: [PATCH 3/5] add changeset Signed-off-by: sandra-greenhalgh --- .changeset/sharp-terms-tap.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/sharp-terms-tap.md diff --git a/.changeset/sharp-terms-tap.md b/.changeset/sharp-terms-tap.md new file mode 100644 index 0000000000..72e888a94e --- /dev/null +++ b/.changeset/sharp-terms-tap.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': patch +--- + +Adding a name to the core-components Tab styles so can customise in the theme settings From 0a5c33c29bd0ba98ff02c3e5a1728bd8b5e0de80 Mon Sep 17 00:00:00 2001 From: sandra-greenhalgh Date: Thu, 31 Mar 2022 17:30:23 +0100 Subject: [PATCH 4/5] Revert unintended changes Signed-off-by: sandra-greenhalgh --- .github/renovate.json5 | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/renovate.json5 b/.github/renovate.json5 index aaf292f8cc..47b10068cc 100644 --- a/.github/renovate.json5 +++ b/.github/renovate.json5 @@ -1,5 +1,4 @@ { labels: ['dependencies'], extends: ['config:base', ':disableDependencyDashboard', ':gitSignOff'], - rangeStrategy: 'update-lockfile', } From 0838db5025e11c877438c89ac49580d5ed61c8bd Mon Sep 17 00:00:00 2001 From: sandra-greenhalgh Date: Thu, 31 Mar 2022 17:51:21 +0100 Subject: [PATCH 5/5] run prettier to fix formatting Signed-off-by: sandra-greenhalgh --- packages/core-components/src/components/Tabs/Tab.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/core-components/src/components/Tabs/Tab.tsx b/packages/core-components/src/components/Tabs/Tab.tsx index 4420ac2925..52c49ba1f8 100644 --- a/packages/core-components/src/components/Tabs/Tab.tsx +++ b/packages/core-components/src/components/Tabs/Tab.tsx @@ -46,7 +46,10 @@ const useStyles = makeStyles( fontSize: theme.typography.pxToRem(13), color: theme.palette.textSubtle, marginLeft: props => - tabMarginLeft(props.isFirstNav as boolean, props.isFirstIndex as boolean), + tabMarginLeft( + props.isFirstNav as boolean, + props.isFirstIndex as boolean, + ), width: '130px', minWidth: '130px', '&:hover': {