chore(review): address comments

Signed-off-by: Phil Kuang <pkuang@factset.com>

plugins/entity-feedback/api-report.md

@@ -10,10 +10,10 @@ import { BackstagePlugin } from '@backstage/core-plugin-api';
 import { DiscoveryApi } from '@backstage/core-plugin-api';
 import { Entity } from '@backstage/catalog-model';
 import { EntityRatingsData } from '@backstage/plugin-entity-feedback-common';
+import { FeedbackResponse } from '@backstage/plugin-entity-feedback-common';
 import { FetchApi } from '@backstage/core-plugin-api';
 import { Rating } from '@backstage/plugin-entity-feedback-common';
 import { ReactNode } from 'react';
-import { Response as Response_2 } from '@backstage/plugin-entity-feedback-common';
 import { RouteRef } from '@backstage/core-plugin-api';
 
 // @public (undocumented)
@@ -25,13 +25,15 @@ export interface EntityFeedbackApi {
   // (undocumented)
   getRatings(entityRef: string): Promise<Omit<Rating, 'entityRef'>[]>;
   // (undocumented)
-  getResponses(entityRef: string): Promise<Omit<Response_2, 'entityRef'>[]>;
+  getResponses(
+    entityRef: string,
+  ): Promise<Omit<FeedbackResponse, 'entityRef'>[]>;
   // (undocumented)
   recordRating(entityRef: string, rating: string): Promise<void>;
   // (undocumented)
   recordResponse(
     entityRef: string,
-    response: Omit<Response_2, 'entityRef' | 'userRef'>,
+    response: Omit<FeedbackResponse, 'entityRef' | 'userRef'>,
   ): Promise<void>;
 }
 
@@ -48,13 +50,15 @@ export class EntityFeedbackClient implements EntityFeedbackApi {
   // (undocumented)
   getRatings(entityRef: string): Promise<Omit<Rating, 'entityRef'>[]>;
   // (undocumented)
-  getResponses(entityRef: string): Promise<Omit<Response_2, 'entityRef'>[]>;
+  getResponses(
+    entityRef: string,
+  ): Promise<Omit<FeedbackResponse, 'entityRef'>[]>;
   // (undocumented)
   recordRating(entityRef: string, rating: string): Promise<void>;
   // (undocumented)
   recordResponse(
     entityRef: string,
-    response: Omit<Response_2, 'entityRef' | 'userRef'>,
+    response: Omit<FeedbackResponse, 'entityRef' | 'userRef'>,
   ): Promise<void>;
 }
 

plugins/entity-feedback/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@backstage/plugin-entity-feedback",
-  "version": "0.1.0",
+  "version": "0.0.0",
   "main": "src/index.ts",
   "types": "src/index.ts",
   "license": "Apache-2.0",

plugins/entity-feedback/src/api/EntityFeedbackApi.ts

@@ -17,8 +17,8 @@
 import { createApiRef } from '@backstage/core-plugin-api';
 import {
   EntityRatingsData,
+  FeedbackResponse,
   Rating,
-  Response,
 } from '@backstage/plugin-entity-feedback-common';
 
 /**
@@ -42,8 +42,10 @@ export interface EntityFeedbackApi {
 
   recordResponse(
     entityRef: string,
-    response: Omit<Response, 'entityRef' | 'userRef'>,
+    response: Omit<FeedbackResponse, 'entityRef' | 'userRef'>,
   ): Promise<void>;
 
-  getResponses(entityRef: string): Promise<Omit<Response, 'entityRef'>[]>;
+  getResponses(
+    entityRef: string,
+  ): Promise<Omit<FeedbackResponse, 'entityRef'>[]>;
 }

plugins/entity-feedback/src/api/EntityFeedbackClient.ts

@@ -18,8 +18,8 @@ import { DiscoveryApi, FetchApi } from '@backstage/core-plugin-api';
 import { ResponseError } from '@backstage/errors';
 import {
   EntityRatingsData,
+  FeedbackResponse,
   Rating,
-  Response,
 } from '@backstage/plugin-entity-feedback-common';
 
 import { EntityFeedbackApi } from './EntityFeedbackApi';
@@ -99,7 +99,7 @@ export class EntityFeedbackClient implements EntityFeedbackApi {
 
   async recordResponse(
     entityRef: string,
-    response: Omit<Response, 'entityRef' | 'userRef'>,
+    response: Omit<FeedbackResponse, 'entityRef' | 'userRef'>,
   ) {
     const baseUrl = await this.discoveryApi.getBaseUrl('entity-feedback');
     const resp = await this.fetchApi.fetch(
@@ -118,7 +118,7 @@ export class EntityFeedbackClient implements EntityFeedbackApi {
 
   async getResponses(
     entityRef: string,
-  ): Promise<Omit<Response, 'entityRef'>[]> {
+  ): Promise<Omit<FeedbackResponse, 'entityRef'>[]> {
     const baseUrl = await this.discoveryApi.getBaseUrl('entity-feedback');
     const resp = await this.fetchApi.fetch(
       `${baseUrl}/responses/${encodeURIComponent(entityRef)}`,

plugins/entity-feedback/src/components/FeedbackResponseTable/FeedbackResponseTable.tsx

@@ -18,7 +18,7 @@ import { parseEntityRef } from '@backstage/catalog-model';
 import { ErrorPanel, Table } from '@backstage/core-components';
 import { useApi } from '@backstage/core-plugin-api';
 import { humanizeEntityRef } from '@backstage/plugin-catalog-react';
-import { Response } from '@backstage/plugin-entity-feedback-common';
+import { FeedbackResponse } from '@backstage/plugin-entity-feedback-common';
 import { BackstageTheme } from '@backstage/theme';
 import { Chip, makeStyles } from '@material-ui/core';
 import CheckIcon from '@material-ui/icons/Check';
@@ -27,7 +27,7 @@ import useAsync from 'react-use/lib/useAsync';
 
 import { entityFeedbackApiRef } from '../../api';
 
-type ResponseRow = Omit<Response, 'entityRef'>;
+type ResponseRow = Omit<FeedbackResponse, 'entityRef'>;
 
 const useStyles = makeStyles<BackstageTheme>(theme => ({
   consentCheck: {