From df17af74d61c4422a546ac63afe568cd70b5ffe4 Mon Sep 17 00:00:00 2001 From: Tim Hansen Date: Tue, 16 Jul 2024 17:41:09 -0400 Subject: [PATCH] Update migration, move test file Signed-off-by: Tim Hansen --- .../migrations/scheduler/20240712211735_nullable_next_run.js | 4 ++++ packages/backend-defaults/{ => src}/migrations.test.ts | 5 ----- .../migrations/20240712211735_nullable_next_run.js | 4 ++++ packages/backend-tasks/src/migrations.test.ts | 5 ----- 4 files changed, 8 insertions(+), 10 deletions(-) rename packages/backend-defaults/{ => src}/migrations.test.ts (96%) diff --git a/packages/backend-defaults/migrations/scheduler/20240712211735_nullable_next_run.js b/packages/backend-defaults/migrations/scheduler/20240712211735_nullable_next_run.js index b636df35d7..efbef1c76f 100644 --- a/packages/backend-defaults/migrations/scheduler/20240712211735_nullable_next_run.js +++ b/packages/backend-defaults/migrations/scheduler/20240712211735_nullable_next_run.js @@ -31,6 +31,10 @@ exports.up = async function up(knex) { * @returns { Promise } */ exports.down = async function down(knex) { + await knex + .delete() + .from('backstage_backend_tasks__tasks') + .where({ next_run_start_at: null }); await knex.schema.alterTable('backstage_backend_tasks__tasks', table => { table.dropNullable('next_run_start_at'); }); diff --git a/packages/backend-defaults/migrations.test.ts b/packages/backend-defaults/src/migrations.test.ts similarity index 96% rename from packages/backend-defaults/migrations.test.ts rename to packages/backend-defaults/src/migrations.test.ts index 98f4e41706..cae127442b 100644 --- a/packages/backend-defaults/migrations.test.ts +++ b/packages/backend-defaults/src/migrations.test.ts @@ -107,11 +107,6 @@ describe('migrations', () => { }, ]); - await knex - .delete() - .from('backstage_backend_tasks__tasks') - .where({ next_run_start_at: null }); - await migrateDownOnce(knex); await expect( diff --git a/packages/backend-tasks/migrations/20240712211735_nullable_next_run.js b/packages/backend-tasks/migrations/20240712211735_nullable_next_run.js index b636df35d7..efbef1c76f 100644 --- a/packages/backend-tasks/migrations/20240712211735_nullable_next_run.js +++ b/packages/backend-tasks/migrations/20240712211735_nullable_next_run.js @@ -31,6 +31,10 @@ exports.up = async function up(knex) { * @returns { Promise } */ exports.down = async function down(knex) { + await knex + .delete() + .from('backstage_backend_tasks__tasks') + .where({ next_run_start_at: null }); await knex.schema.alterTable('backstage_backend_tasks__tasks', table => { table.dropNullable('next_run_start_at'); }); diff --git a/packages/backend-tasks/src/migrations.test.ts b/packages/backend-tasks/src/migrations.test.ts index 49576d8a58..7583948f71 100644 --- a/packages/backend-tasks/src/migrations.test.ts +++ b/packages/backend-tasks/src/migrations.test.ts @@ -107,11 +107,6 @@ describe('migrations', () => { }, ]); - await knex - .delete() - .from('backstage_backend_tasks__tasks') - .where({ next_run_start_at: null }); - await migrateDownOnce(knex); await expect(