From ded44b374dc5ad4fdfe7ef82abd674dc5dcc6f0f Mon Sep 17 00:00:00 2001 From: Jake Crews Date: Fri, 26 Aug 2022 06:57:35 -0500 Subject: [PATCH] address pr comments with typing Signed-off-by: Jake Crews --- .../EntityTeamPullRequestsCard.tsx | 4 +-- .../EntityTeamPullRequestsContent.tsx | 6 ++--- .../github-pull-requests-board/src/plugin.ts | 27 +++++++++---------- 3 files changed, 16 insertions(+), 21 deletions(-) diff --git a/plugins/github-pull-requests-board/src/components/EntityTeamPullRequestsCard/EntityTeamPullRequestsCard.tsx b/plugins/github-pull-requests-board/src/components/EntityTeamPullRequestsCard/EntityTeamPullRequestsCard.tsx index 9f0cff33ef..e22397082a 100644 --- a/plugins/github-pull-requests-board/src/components/EntityTeamPullRequestsCard/EntityTeamPullRequestsCard.tsx +++ b/plugins/github-pull-requests-board/src/components/EntityTeamPullRequestsCard/EntityTeamPullRequestsCard.tsx @@ -33,9 +33,7 @@ export interface EntityTeamPullRequestsCardProps { defaultLimit?: number; } -const EntityTeamPullRequestsCard: FunctionComponent< - EntityTeamPullRequestsCardProps -> = (props: EntityTeamPullRequestsCardProps) => { +const EntityTeamPullRequestsCard = (props: EntityTeamPullRequestsCardProps) => { const { defaultLimit = 100 } = props; const [infoCardFormat, setInfoCardFormat] = useState([]); const { repositories } = useUserRepositories(); diff --git a/plugins/github-pull-requests-board/src/components/EntityTeamPullRequestsContent/EntityTeamPullRequestsContent.tsx b/plugins/github-pull-requests-board/src/components/EntityTeamPullRequestsContent/EntityTeamPullRequestsContent.tsx index 64be8e6710..22233e5adf 100644 --- a/plugins/github-pull-requests-board/src/components/EntityTeamPullRequestsContent/EntityTeamPullRequestsContent.tsx +++ b/plugins/github-pull-requests-board/src/components/EntityTeamPullRequestsContent/EntityTeamPullRequestsContent.tsx @@ -31,9 +31,9 @@ export interface EntityTeamPullRequestsContentProps { defaultLimit?: number; } -const EntityTeamPullRequestsContent: FunctionComponent< - EntityTeamPullRequestsContentProps -> = (props: EntityTeamPullRequestsContentProps) => { +const EntityTeamPullRequestsContent = ( + props: EntityTeamPullRequestsContentProps, +) => { const { defaultLimit } = props; const [infoCardFormat, setInfoCardFormat] = useState([]); const { repositories } = useUserRepositories(); diff --git a/plugins/github-pull-requests-board/src/plugin.ts b/plugins/github-pull-requests-board/src/plugin.ts index c0514f335c..c8c3b489d2 100644 --- a/plugins/github-pull-requests-board/src/plugin.ts +++ b/plugins/github-pull-requests-board/src/plugin.ts @@ -30,9 +30,7 @@ const githubPullRequestsBoardPlugin = createPlugin({ }); /** @public */ -export const EntityTeamPullRequestsCard: ( - props: EntityTeamPullRequestsCardProps, -) => JSX.Element | null = githubPullRequestsBoardPlugin.provide( +export const EntityTeamPullRequestsCard = githubPullRequestsBoardPlugin.provide( createComponentExtension({ name: 'EntityTeamPullRequestsCard', component: { @@ -45,15 +43,14 @@ export const EntityTeamPullRequestsCard: ( ); /** @public */ -export const EntityTeamPullRequestsContent: ( - props: EntityTeamPullRequestsContentProps, -) => JSX.Element | null = githubPullRequestsBoardPlugin.provide( - createRoutableExtension({ - name: 'PullRequestPage', - component: () => - import('./components/EntityTeamPullRequestsContent').then( - m => m.EntityTeamPullRequestsContent, - ), - mountPoint: rootRouteRef, - }), -); +export const EntityTeamPullRequestsContent = + githubPullRequestsBoardPlugin.provide( + createRoutableExtension({ + name: 'PullRequestPage', + component: () => + import('./components/EntityTeamPullRequestsContent').then( + m => m.EntityTeamPullRequestsContent, + ), + mountPoint: rootRouteRef, + }), + );