chore: fixing code review comments

Signed-off-by: blam <ben@blam.sh>

plugins/scaffolder/src/next/Router/Router.tsx

@@ -28,13 +28,8 @@ import {
 import { useElementFilter } from '@backstage/core-plugin-api';
 import { TemplateEntityV1beta3 } from '@backstage/plugin-scaffolder-common';
 import { TemplateGroupFilter } from '../TemplateListPage/TemplateGroups';
-import {
-  nextScaffolderTaskRouteRef,
-  nextSelectedTemplateRouteRef,
-} from '../../routes';
+import { nextSelectedTemplateRouteRef } from '../../routes';
 import { SecretsContextProvider } from '../../components/secrets/SecretsContext';
-import { TaskPage } from '../TaskPage';
-import { ErrorPage } from '@backstage/core-components';
 
 /**
  * The Props for the Scaffolder Router
@@ -100,11 +95,6 @@ export const Router = (props: PropsWithChildren<NextRouterProps>) => {
           </SecretsContextProvider>
         }
       />
-      <Route path={nextScaffolderTaskRouteRef.path} element={<TaskPage />} />
-      <Route
-        path="*"
-        element={<ErrorPage status="404" statusMessage="Page not found" />}
-      />
     </Routes>
   );
 };

plugins/scaffolder/src/next/TaskPage/TaskPage.tsx

@@ -1,33 +0,0 @@
-/*
- * Copyright 2022 The Backstage Authors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import React from 'react';
-import { Page, Header, Content } from '@backstage/core-components';
-
-export const TaskPage = () => {
-  return (
-    <Page themeId="website">
-      <Header
-        pageTitleOverride="Task ID"
-        title="View Task"
-        subtitle="View the status of a task"
-      />
-      <Content>
-        <p>Hey</p>
-      </Content>
-    </Page>
-  );
-};

plugins/scaffolder/src/next/TaskPage/index.ts

@@ -1,16 +0,0 @@
-/*
- * Copyright 2022 The Backstage Authors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-export { TaskPage } from './TaskPage';