From 5f0bb1dfb51c600425b6de9e66ceaaadf707bfd4 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Wed, 23 Dec 2020 14:27:48 -0500 Subject: [PATCH 1/5] Fix typo and rewording --- .../ProjectGrowthInstructionsPage.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/cost-insights/src/components/ProjectGrowthInstructionsPage/ProjectGrowthInstructionsPage.tsx b/plugins/cost-insights/src/components/ProjectGrowthInstructionsPage/ProjectGrowthInstructionsPage.tsx index 4fcc34c87f..dcd33a02e8 100644 --- a/plugins/cost-insights/src/components/ProjectGrowthInstructionsPage/ProjectGrowthInstructionsPage.tsx +++ b/plugins/cost-insights/src/components/ProjectGrowthInstructionsPage/ProjectGrowthInstructionsPage.tsx @@ -101,7 +101,7 @@ export const ProjectGrowthInstructionsPage = () => { Investigating cloud cost growth Cost Insights shows an alert when costs for a particular billing entity, - such as a GCP project, have grown at a rate faster than our alerting + such as a GCP project, has grown at a rate faster than our alerting threshold. The responsible team should follow this guide to decide whether this warrants further investigation. @@ -135,7 +135,7 @@ export const ProjectGrowthInstructionsPage = () => { Next, evaluate whether the growth is significant. This helps avoid premature optimization, where cost in engineering time is more than - would be saved from the optimization over a reasonable timeframe. + would be saved from the optimization over a reasonable time frame. We recommend reframing the cost growth itself in terms of engineering @@ -205,7 +205,7 @@ export const ProjectGrowthInstructionsPage = () => { Is the workload using cloud resources efficiently? For compute resources, do the utilization metrics look reasonable? Autoscaling infrastructure, such as Kubernetes, can run workloads more efficiently - without comprimising reliability. + without compromising reliability. Lifecycle From f1462655f9ce8c06ce7b286d3b16c90e7acb8275 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Wed, 23 Dec 2020 14:28:11 -0500 Subject: [PATCH 2/5] Display links properly in label instructions --- .../LabelDataflowInstructionsPage.tsx | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/plugins/cost-insights/src/components/LabelDataflowInstructionsPage/LabelDataflowInstructionsPage.tsx b/plugins/cost-insights/src/components/LabelDataflowInstructionsPage/LabelDataflowInstructionsPage.tsx index 3442de49fc..ba5a22e932 100644 --- a/plugins/cost-insights/src/components/LabelDataflowInstructionsPage/LabelDataflowInstructionsPage.tsx +++ b/plugins/cost-insights/src/components/LabelDataflowInstructionsPage/LabelDataflowInstructionsPage.tsx @@ -15,7 +15,7 @@ */ import React from 'react'; -import { Box, Typography } from '@material-ui/core'; +import { Box, Typography, Link } from '@material-ui/core'; import { CodeSnippet } from '@backstage/core'; import { AlertInstructionsLayout } from '../AlertInstructionsLayout'; @@ -31,10 +31,10 @@ export const LabelDataflowInstructionsPage = () => { In Cloud Dataflow, labels can be added to a job either programmatically - or via the command-line when launching a job. Note that GCP has - + or via the command-line when launching a job. Note that GCP has{' '} + restrictions - {' '} + {' '} on the length and characters that can be used in labels. @@ -46,9 +46,9 @@ export const LabelDataflowInstructionsPage = () => { DataflowPipelineOptions Dataflow jobs using Beam's{' '} - + DataflowPipelineOptions - {' '} + {' '} directly can use the setLabels function to add one or more labels: "my-dataflow-job For more information on specifying options, see the{' '} - + Dataflow documentation - {' '} + {' '} or{' '} - + Scio Scaladoc - + . From 3fca9adb97a9062612ea5b9feef4f1d875ccaf67 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Wed, 23 Dec 2020 14:31:35 -0500 Subject: [PATCH 3/5] Add changeset --- .changeset/lucky-fans-wait.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/lucky-fans-wait.md diff --git a/.changeset/lucky-fans-wait.md b/.changeset/lucky-fans-wait.md new file mode 100644 index 0000000000..439d943c65 --- /dev/null +++ b/.changeset/lucky-fans-wait.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-cost-insights': patch +--- + +Fix links in sample instructions From 51f55e5105890b1e3e8bd8e8e55e3b4efa120466 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Wed, 23 Dec 2020 15:08:13 -0500 Subject: [PATCH 4/5] Return wording --- .../ProjectGrowthInstructionsPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/cost-insights/src/components/ProjectGrowthInstructionsPage/ProjectGrowthInstructionsPage.tsx b/plugins/cost-insights/src/components/ProjectGrowthInstructionsPage/ProjectGrowthInstructionsPage.tsx index dcd33a02e8..02b66b0fd1 100644 --- a/plugins/cost-insights/src/components/ProjectGrowthInstructionsPage/ProjectGrowthInstructionsPage.tsx +++ b/plugins/cost-insights/src/components/ProjectGrowthInstructionsPage/ProjectGrowthInstructionsPage.tsx @@ -101,7 +101,7 @@ export const ProjectGrowthInstructionsPage = () => { Investigating cloud cost growth Cost Insights shows an alert when costs for a particular billing entity, - such as a GCP project, has grown at a rate faster than our alerting + such as a GCP project, have grown at a rate faster than our alerting threshold. The responsible team should follow this guide to decide whether this warrants further investigation. From 8a53d92299aa85f8ffe242e60860161013ad344d Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 28 Dec 2020 16:25:28 -0500 Subject: [PATCH 5/5] Change Link to use backstage/core --- .../LabelDataflowInstructionsPage.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/plugins/cost-insights/src/components/LabelDataflowInstructionsPage/LabelDataflowInstructionsPage.tsx b/plugins/cost-insights/src/components/LabelDataflowInstructionsPage/LabelDataflowInstructionsPage.tsx index ba5a22e932..c3f4b4f79c 100644 --- a/plugins/cost-insights/src/components/LabelDataflowInstructionsPage/LabelDataflowInstructionsPage.tsx +++ b/plugins/cost-insights/src/components/LabelDataflowInstructionsPage/LabelDataflowInstructionsPage.tsx @@ -15,8 +15,8 @@ */ import React from 'react'; -import { Box, Typography, Link } from '@material-ui/core'; -import { CodeSnippet } from '@backstage/core'; +import { Box, Typography } from '@material-ui/core'; +import { CodeSnippet, Link } from '@backstage/core'; import { AlertInstructionsLayout } from '../AlertInstructionsLayout'; export const LabelDataflowInstructionsPage = () => { @@ -32,7 +32,7 @@ export const LabelDataflowInstructionsPage = () => { In Cloud Dataflow, labels can be added to a job either programmatically or via the command-line when launching a job. Note that GCP has{' '} - + restrictions {' '} on the length and characters that can be used in labels. @@ -46,7 +46,7 @@ export const LabelDataflowInstructionsPage = () => { DataflowPipelineOptions Dataflow jobs using Beam's{' '} - + DataflowPipelineOptions {' '} directly can use the setLabels function to add one or more @@ -79,11 +79,11 @@ sc.optionsAs[DataflowPipelineOptions].setLabels(Map("job-id" -> "my-dataflow-job For more information on specifying options, see the{' '} - + Dataflow documentation {' '} or{' '} - + Scio Scaladoc .