From de4c3af8674950a0f3f996caf54cafdf45d4b786 Mon Sep 17 00:00:00 2001
From: Himanshu Mishra <himanshu@orkohunter.net>
Date: Sun, 10 Jan 2021 10:09:42 +0100
Subject: [PATCH] fix(techdocs): Handle images and other binaries correctly in
 aws/gcs publishers

Closes https://github.com/backstage/backstage/issues/3990
---
 packages/techdocs-common/src/stages/publish/awsS3.ts         | 2 +-
 packages/techdocs-common/src/stages/publish/googleStorage.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/techdocs-common/src/stages/publish/awsS3.ts b/packages/techdocs-common/src/stages/publish/awsS3.ts
index 15ff33408a..a17bd25011 100644
--- a/packages/techdocs-common/src/stages/publish/awsS3.ts
+++ b/packages/techdocs-common/src/stages/publish/awsS3.ts
@@ -186,7 +186,7 @@ export class AwsS3Publish implements PublisherBase {
           fileStreamChunks.push(chunk);
         })
         .on('end', () => {
-          const fileContent = Buffer.concat(fileStreamChunks).toString();
+          const fileContent = Buffer.concat(fileStreamChunks);
           // Inject response headers
           for (const [headerKey, headerValue] of Object.entries(
             responseHeaders,
diff --git a/packages/techdocs-common/src/stages/publish/googleStorage.ts b/packages/techdocs-common/src/stages/publish/googleStorage.ts
index b33e2bfbe0..12a92aeb53 100644
--- a/packages/techdocs-common/src/stages/publish/googleStorage.ts
+++ b/packages/techdocs-common/src/stages/publish/googleStorage.ts
@@ -184,7 +184,7 @@ export class GoogleGCSPublish implements PublisherBase {
           fileStreamChunks.push(chunk);
         })
         .on('end', () => {
-          const fileContent = Buffer.concat(fileStreamChunks).toString();
+          const fileContent = Buffer.concat(fileStreamChunks);
           // Inject response headers
           for (const [headerKey, headerValue] of Object.entries(
             responseHeaders,