From ddb7060e081d54019dfbded8227b5fd8ac862e48 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Fri, 16 Feb 2024 12:18:35 +0100
Subject: [PATCH] backend-plugin-api: switch principal mapping to use none
 instead of unauthenticated

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 packages/backend-plugin-api/api-report.md                     | 2 +-
 .../src/services/definitions/AuthService.ts                   | 2 +-
 .../src/next/services/MockHttpAuthService.ts                  | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/backend-plugin-api/api-report.md b/packages/backend-plugin-api/api-report.md
index 320e05dd3d..d676de2fce 100644
--- a/packages/backend-plugin-api/api-report.md
+++ b/packages/backend-plugin-api/api-report.md
@@ -115,7 +115,7 @@ export type BackstageNonePrincipal = {
 export type BackstagePrincipalTypes = {
   user: BackstageUserPrincipal;
   service: BackstageServicePrincipal;
-  unauthenticated: BackstageNonePrincipal;
+  none: BackstageNonePrincipal;
   unknown: unknown;
 };
 
diff --git a/packages/backend-plugin-api/src/services/definitions/AuthService.ts b/packages/backend-plugin-api/src/services/definitions/AuthService.ts
index dc38b572c5..eab0a7fac7 100644
--- a/packages/backend-plugin-api/src/services/definitions/AuthService.ts
+++ b/packages/backend-plugin-api/src/services/definitions/AuthService.ts
@@ -55,7 +55,7 @@ export type BackstageCredentials<TPrincipal = unknown> = {
 export type BackstagePrincipalTypes = {
   user: BackstageUserPrincipal;
   service: BackstageServicePrincipal;
-  unauthenticated: BackstageNonePrincipal;
+  none: BackstageNonePrincipal;
   unknown: unknown;
 };
 
diff --git a/packages/backend-test-utils/src/next/services/MockHttpAuthService.ts b/packages/backend-test-utils/src/next/services/MockHttpAuthService.ts
index d63d8a1769..02eb305915 100644
--- a/packages/backend-test-utils/src/next/services/MockHttpAuthService.ts
+++ b/packages/backend-test-utils/src/next/services/MockHttpAuthService.ts
@@ -60,13 +60,13 @@ export class MockHttpAuthService implements HttpAuthService {
       return credentials as any;
     }
 
-    if (this.#auth.isPrincipal(credentials, 'unauthenticated')) {
+    if (this.#auth.isPrincipal(credentials, 'none')) {
       if (allowedPrincipalTypes.includes('none' as TAllowed)) {
         return credentials as any;
       }
 
       throw new NotAllowedError(
-        `This endpoint does not allow 'unauthenticated' credentials`,
+        `This endpoint does not allow 'none' credentials`,
       );
     } else if (this.#auth.isPrincipal(credentials, 'user')) {
       if (allowedPrincipalTypes.includes('user' as TAllowed)) {