From dd269e92f0c160364d373095dbfa8dac89141933 Mon Sep 17 00:00:00 2001 From: Steve Zhang Date: Thu, 4 Apr 2024 22:30:41 -0400 Subject: [PATCH] Fix for #23999 - 'req.header is not a function' Signed-off-by: Steve Zhang --- .changeset/curly-news-report.md | 21 +++++++++++++++++++ .../src/service/KubernetesProxy.ts | 2 +- 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 .changeset/curly-news-report.md diff --git a/.changeset/curly-news-report.md b/.changeset/curly-news-report.md new file mode 100644 index 0000000000..f2a7dee6d1 --- /dev/null +++ b/.changeset/curly-news-report.md @@ -0,0 +1,21 @@ +--- +'@backstage/plugin-kubernetes-backend': patch +--- + +**BREAKING** The kubernetes backend now can handle when req.header is undefined. + +These changes are **required** to `plugins/kubernetes-backend/src/service/KubernetesProxy.ts` + +```diff +-- a/plugins/kubernetes-backend/src/service/KubernetesProxy.ts ++++ b/plugins/kubernetes-backend/src/service/KubernetesProxy.ts +@@ -172,7 +172,7 @@ export class KubernetesProxy { + )?.toString(), + }; + +- const authHeader = req.header(HEADER_KUBERNETES_AUTH); ++ const authHeader = req.header?.(HEADER_KUBERNETES_AUTH); + if (authHeader) { + req.headers.authorization = authHeader; + } else { +``` diff --git a/plugins/kubernetes-backend/src/service/KubernetesProxy.ts b/plugins/kubernetes-backend/src/service/KubernetesProxy.ts index b4536c5880..15b99e4180 100644 --- a/plugins/kubernetes-backend/src/service/KubernetesProxy.ts +++ b/plugins/kubernetes-backend/src/service/KubernetesProxy.ts @@ -172,7 +172,7 @@ export class KubernetesProxy { )?.toString(), }; - const authHeader = req.header(HEADER_KUBERNETES_AUTH); + const authHeader = req.header?.(HEADER_KUBERNETES_AUTH); if (authHeader) { req.headers.authorization = authHeader; } else {