paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

xcmetrics: removed hidden build details route

Browse Source 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
This commit is contained in:
Patrik Oldsberg
2022-10-20 11:34:37 +02:00
parent 8db366cc4c
commit dcf9e728de
5 changed files with 7 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/spotty-dryers-explain.md
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-xcmetrics': patch
---
Removed an unused and hidden build details route.
plugins/xcmetrics/src/components/BuildsPage/BuildsPage.test.tsx
-43
View File
@@ -1,43 +0,0 @@
/*
* Copyright 2021 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import React from 'react';
import { renderInTestApp } from '@backstage/test-utils';
import { BuildsPage } from './BuildsPage';
jest.mock('../BuildDetails', () => ({
withRequest: (component: any) => component,
BuildDetails: () => 'BuildDetails',
}));
jest.mock('../BuildList', () => ({
BuildList: () => 'BuildList',
}));
describe('BuildPage', () => {
it('should render BuildDetails if build id is provided in path', async () => {
const rendered = await renderInTestApp(<BuildsPage />, {
routeEntries: [`/buildId`],
});
expect(rendered.getByText('BuildDetails')).toBeInTheDocument();
});
it('should render BuildList if no build id is provided in path', async () => {
const rendered = await renderInTestApp(<BuildsPage />);
expect(rendered.getByText('BuildList')).toBeInTheDocument();
});
});
plugins/xcmetrics/src/components/BuildsPage/BuildsPage.tsx
-37
View File
@@ -1,37 +0,0 @@
/*
* Copyright 2021 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import React from 'react';
import { useRouteRefParams } from '@backstage/core-plugin-api';
import { buildsRouteRef } from '../../routes';
import { BuildList } from '../BuildList';
import { BuildDetails, withRequest } from '../BuildDetails';
import { InfoCard } from '@backstage/core-components';
export const BuildsPage = () => {
const { '*': buildId } = useRouteRefParams(buildsRouteRef) ?? { '*': '' };
if (buildId) {
const BuildDetailsWithRequest = withRequest(BuildDetails);
return (
<InfoCard title="Build Details" subheader={buildId}>
<BuildDetailsWithRequest buildId={buildId} showId={false} />
</InfoCard>
);
}
return <BuildList />;
};
plugins/xcmetrics/src/components/BuildsPage/index.ts
-16
View File
@@ -1,16 +0,0 @@
/*
* Copyright 2021 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
export { BuildsPage } from './BuildsPage';
plugins/xcmetrics/src/components/XcmetricsLayout/XcmetricsLayout.tsx
+2 -2
View File
@@ -23,7 +23,7 @@ import {
} from '@backstage/core-components';
import { Overview } from '../Overview';
import { buildsRouteRef } from '../../routes';
import { BuildsPage } from '../BuildsPage';
import { BuildList } from '../BuildList';
export interface TabConfig {
path: string;
@@ -40,7 +40,7 @@ const TABS: TabConfig[] = [
{
path: buildsRouteRef.path,
title: 'Builds',
component: <BuildsPage />,
component: <BuildList />,
},
];