From dcf632695a1e49837729bdc726e620038da75977 Mon Sep 17 00:00:00 2001 From: blam Date: Thu, 6 Oct 2022 12:52:36 +0200 Subject: [PATCH] chore: also fix repoName setting when there's no default Signed-off-by: blam --- .../components/fields/RepoUrlPicker/RepoUrlPicker.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPicker.tsx b/plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPicker.tsx index d0c3108976..451df857e5 100644 --- a/plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPicker.tsx +++ b/plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPicker.tsx @@ -88,7 +88,7 @@ export const RepoUrlPicker = ( [uiSchema], ); - const { owner, organization } = state; + const { owner, organization, repoName } = state; useEffect(() => { onChange(serializeRepoPickerUrl(state)); @@ -114,10 +114,10 @@ export const RepoUrlPicker = ( }, [setState, allowedOwners, owner]); useEffect(() => { - if (allowedRepos.length > 0) { + if (allowedRepos.length > 0 && !repoName) { setState(prevState => ({ ...prevState, repoName: allowedRepos[0] })); } - }, [setState, allowedRepos]); + }, [setState, allowedRepos, repoName]); const updateLocalState = useCallback( (newState: RepoUrlPickerState) => { @@ -216,8 +216,8 @@ export const RepoUrlPicker = ( - setState(prevState => ({ ...prevState, repoName })) + onChange={repo => + setState(prevState => ({ ...prevState, repoName: repo })) } rawErrors={rawErrors} />