From dcce6f5d10d3381f9883d9c60c4afc9705046057 Mon Sep 17 00:00:00 2001 From: Miguel Alexandre Date: Fri, 9 Dec 2022 16:48:04 +0100 Subject: [PATCH] Fix tests Signed-off-by: Miguel Alexandre --- .../actions/builtin/github/githubRepoPush.test.ts | 10 ++++++++++ .../scaffolder/actions/builtin/publish/github.test.ts | 10 ++++++++++ 2 files changed, 20 insertions(+) diff --git a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/github/githubRepoPush.test.ts b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/github/githubRepoPush.test.ts index dfd3297b87..46f33a823d 100644 --- a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/github/githubRepoPush.test.ts +++ b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/github/githubRepoPush.test.ts @@ -285,6 +285,7 @@ describe('github:repo:push', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -305,6 +306,7 @@ describe('github:repo:push', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -325,6 +327,7 @@ describe('github:repo:push', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); }); @@ -348,6 +351,7 @@ describe('github:repo:push', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -368,6 +372,7 @@ describe('github:repo:push', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -388,6 +393,7 @@ describe('github:repo:push', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: false, + dismissStaleReviews: false, }); }); @@ -411,6 +417,7 @@ describe('github:repo:push', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -432,6 +439,7 @@ describe('github:repo:push', () => { requiredStatusCheckContexts: ['statusCheck'], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -453,6 +461,7 @@ describe('github:repo:push', () => { requiredStatusCheckContexts: ['statusCheck'], requireBranchesToBeUpToDate: false, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -474,6 +483,7 @@ describe('github:repo:push', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); }); diff --git a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/github.test.ts b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/github.test.ts index 6c4cd55d98..b5bda4c5d0 100644 --- a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/github.test.ts +++ b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/github.test.ts @@ -671,6 +671,7 @@ describe('publish:github', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -691,6 +692,7 @@ describe('publish:github', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -711,6 +713,7 @@ describe('publish:github', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); }); @@ -737,6 +740,7 @@ describe('publish:github', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -757,6 +761,7 @@ describe('publish:github', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: false, + dismissStaleReviews: false, }); await action.handler({ @@ -777,6 +782,7 @@ describe('publish:github', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); }); @@ -803,6 +809,7 @@ describe('publish:github', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -824,6 +831,7 @@ describe('publish:github', () => { requiredStatusCheckContexts: ['statusCheck'], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -845,6 +853,7 @@ describe('publish:github', () => { requiredStatusCheckContexts: ['statusCheck'], requireBranchesToBeUpToDate: false, enforceAdmins: true, + dismissStaleReviews: false, }); await action.handler({ @@ -865,6 +874,7 @@ describe('publish:github', () => { requiredStatusCheckContexts: [], requireBranchesToBeUpToDate: true, enforceAdmins: true, + dismissStaleReviews: false, }); });