From dc5b8f7b3083df1dfa3db9abc5429104dd08b18f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gustaf=20R=C3=A4ntil=C3=A4?= Date: Wed, 9 Nov 2022 10:22:42 +0100 Subject: [PATCH] chore(version-bridge): Removed highest-version shortcut, and made the map configurable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Gustaf Räntilä --- .changeset/early-jars-laugh.md | 2 +- packages/version-bridge/src/lib/VersionedValue.ts | 12 +----------- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/.changeset/early-jars-laugh.md b/.changeset/early-jars-laugh.md index 1cf0a0e036..9b9de4ab80 100644 --- a/.changeset/early-jars-laugh.md +++ b/.changeset/early-jars-laugh.md @@ -1,5 +1,5 @@ --- -'@backstage/version-bridge': minor +'@backstage/version-bridge': patch --- Debuggable/inspectable versioned values diff --git a/packages/version-bridge/src/lib/VersionedValue.ts b/packages/version-bridge/src/lib/VersionedValue.ts index cc8ae2aeae..51a9fd7879 100644 --- a/packages/version-bridge/src/lib/VersionedValue.ts +++ b/packages/version-bridge/src/lib/VersionedValue.ts @@ -41,18 +41,8 @@ export function createVersionedValueMap< return versions[version]; }, }; - Object.defineProperty(versionedValue, '$value', { - configurable: false, - enumerable: true, - get() { - const highest = Object.keys(versions) - .map(v => parseInt(v, 10)) - .sort((a, b) => b - a)[0]; - return versions[highest]; - }, - }); Object.defineProperty(versionedValue, '$map', { - configurable: false, + configurable: true, enumerable: true, get() { return versions;