chore: fix up the migrations a little bit so that it supports adding columns

Signed-off-by: benjdlambert <ben@blam.sh>
This commit is contained in:
benjdlambert
2025-07-08 09:48:46 +02:00
parent b748b42f63
commit dc32e0c8a2
3 changed files with 50 additions and 4 deletions
@@ -22,12 +22,25 @@
exports.up = async function up(knex) {
await knex.schema.alterTable('user_info', table => {
table.renameColumn('exp', 'updated_at');
});
// Sqlite doesn't support adding a column with non-constant default when table has data
// so we need to add it as nullable first, then set the value to the updated_at value
await knex.schema.alterTable('user_info', table => {
table.timestamp('created_at').nullable();
});
await knex('user_info').update({
created_at: knex.ref('updated_at'),
});
// Then alter to non-nullable and set the default to now()
await knex.schema.alterTable('user_info', table => {
table
.timestamp('created_at')
.notNullable()
.defaultTo(knex.fn.now())
.comment('The creation time of the user info');
.alter();
});
};
@@ -36,7 +49,7 @@ exports.up = async function up(knex) {
*/
exports.down = async function down(knex) {
await knex.schema.alterTable('user_info', table => {
table.renameColumn('updated_at', 'exp');
table.dropColumn('created_at');
table.renameColumn('updated_at', 'exp');
});
};
@@ -40,7 +40,7 @@ export class UserInfoDatabase {
.insert({
user_entity_ref: userInfo.claims.sub as string,
user_info: JSON.stringify(userInfo),
updated_at: DateTime.now().toSQL({ includeOffset: false }),
updated_at: DateTime.utc().toSQL(),
})
.onConflict('user_entity_ref')
.merge();
+34 -1
View File
@@ -136,8 +136,41 @@ describe('migrations', () => {
const { created_at, updated_at } = await knex('user_info').first();
expect(updated_at).toBe(exp);
expect(created_at).toBeDefined();
await knex
.insert({
user_entity_ref: 'user:default/backstage-user',
user_info,
updated_at: knex.fn.now(),
})
.into('user_info')
.onConflict(['user_entity_ref'])
.merge();
await knex
.insert({
user_entity_ref: 'user:default/backstage-user-2',
user_info,
updated_at: knex.fn.now(),
})
.into('user_info');
await expect(
knex('user_info').select('created_at', 'updated_at'),
).resolves.toEqual([
{ created_at: expect.any(String), updated_at: expect.any(String) },
{ created_at: expect.any(String), updated_at: expect.any(String) },
]);
await migrateDownOnce(knex);
await expect(knex('user_info').select('exp')).resolves.toEqual([
{ exp: expect.any(String) },
{ exp: expect.any(String) },
]);
await knex.destroy();
},
);
});