From dbe239808d18aa1adb877ff7d8dda3c34e403ab6 Mon Sep 17 00:00:00 2001 From: blam Date: Tue, 22 Feb 2022 13:10:39 +0100 Subject: [PATCH] chore: encodeURIComponent Signed-off-by: blam diff --git c/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts i/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts index ca70084ef5..9efc11210a 100644 --- c/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts +++ i/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts @@ -65,10 +65,14 @@ export const defaultClientFactory = async ({ host = 'github.com', token: providedToken, }: ClientFactoryInput): Promise => { + const [encodedHost, encodedOwner, encodedRepo] = [host, owner, repo].map( + encodeURIComponent, + ); + const octokitOptions = await getOctokitOptions({ integrations, credentialsProvider: githubCredentialsProvider, - repoUrl: `https://${host}/${owner}/${repo}`, + repoUrl: `https://${encodedHost}/${encodedOwner}/${encodedRepo}`, token: providedToken, }); --- .../scaffolder/actions/builtin/publish/githubPullRequest.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts index ca70084ef5..9efc11210a 100644 --- a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts +++ b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts @@ -65,10 +65,14 @@ export const defaultClientFactory = async ({ host = 'github.com', token: providedToken, }: ClientFactoryInput): Promise => { + const [encodedHost, encodedOwner, encodedRepo] = [host, owner, repo].map( + encodeURIComponent, + ); + const octokitOptions = await getOctokitOptions({ integrations, credentialsProvider: githubCredentialsProvider, - repoUrl: `https://${host}/${owner}/${repo}`, + repoUrl: `https://${encodedHost}/${encodedOwner}/${encodedRepo}`, token: providedToken, });