From 1f622289218f917dde15dce7a23848102d3e2d59 Mon Sep 17 00:00:00 2001 From: Karl Haworth <58607256+karlhaworth@users.noreply.github.com> Date: Wed, 13 Mar 2024 06:35:38 -0400 Subject: [PATCH 1/2] Update plugins/apollo-explorer/src/components/ApolloExplorerPage/ApolloExplorerPage.tsx Co-authored-by: Vincenzo Scamporlino Signed-off-by: Karl Haworth <58607256+karlhaworth@users.noreply.github.com> --- .../src/components/ApolloExplorerPage/ApolloExplorerPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/apollo-explorer/src/components/ApolloExplorerPage/ApolloExplorerPage.tsx b/plugins/apollo-explorer/src/components/ApolloExplorerPage/ApolloExplorerPage.tsx index 0a0ea0ccdc..a3eb44362a 100644 --- a/plugins/apollo-explorer/src/components/ApolloExplorerPage/ApolloExplorerPage.tsx +++ b/plugins/apollo-explorer/src/components/ApolloExplorerPage/ApolloExplorerPage.tsx @@ -63,7 +63,7 @@ export const ApolloExplorerPage = (props: Props) => { return await endpoints({ apiHolder }); } return endpoints; - }, []); + }, [endpoints]); return ( From ddf05c64932119575b434d523e0ac0364baa8dd6 Mon Sep 17 00:00:00 2001 From: Karl Haworth <58607256+karlhaworth@users.noreply.github.com> Date: Mon, 1 Apr 2024 07:20:27 -0400 Subject: [PATCH 2/2] add type Co-authored-by: Patrik Oldsberg Signed-off-by: Karl Haworth <58607256+karlhaworth@users.noreply.github.com> --- plugins/apollo-explorer/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/apollo-explorer/README.md b/plugins/apollo-explorer/README.md index 71cb76c592..78c8920814 100644 --- a/plugins/apollo-explorer/README.md +++ b/plugins/apollo-explorer/README.md @@ -83,7 +83,7 @@ import { ApiHolder } from '@backstage/core-plugin-api'; async function apolloPluginEndpointsCallback(options: { apiHolder: ApiHolder }): Promise { - const sso = options.apiHolder.get(ssoAuthApiRef) + const sso = options.apiHolder.get(ssoAuthApiRef) return [{ title: 'Github', graphRef: 'my-github-graph-ref@current',