From c4a5653825d6f665af01f9ff3a6a3bacba398f30 Mon Sep 17 00:00:00 2001 From: Aj-vrod Date: Thu, 16 Sep 2021 15:59:32 +0200 Subject: [PATCH 1/2] minor changes to table columns Signed-off-by: Aj-vrod --- plugins/api-docs/src/components/ApisCards/HasApisCard.tsx | 2 +- plugins/api-docs/src/components/ApisCards/presets.tsx | 2 +- plugins/catalog-react/src/components/EntityTable/columns.tsx | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx b/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx index 71300eee7d..c3d79414c2 100644 --- a/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx +++ b/plugins/api-docs/src/components/ApisCards/HasApisCard.tsx @@ -39,8 +39,8 @@ type Props = { const columns: TableColumn[] = [ EntityTable.columns.createEntityRefColumn({ defaultKind: 'API' }), EntityTable.columns.createOwnerColumn(), - EntityTable.columns.createSpecLifecycleColumn(), createSpecApiTypeColumn(), + EntityTable.columns.createSpecLifecycleColumn(), EntityTable.columns.createMetadataDescriptionColumn(), ]; diff --git a/plugins/api-docs/src/components/ApisCards/presets.tsx b/plugins/api-docs/src/components/ApisCards/presets.tsx index 07fcb45b72..4a0a0f429e 100644 --- a/plugins/api-docs/src/components/ApisCards/presets.tsx +++ b/plugins/api-docs/src/components/ApisCards/presets.tsx @@ -36,7 +36,7 @@ export const apiEntityColumns: TableColumn[] = [ EntityTable.columns.createEntityRefColumn({ defaultKind: 'API' }), EntityTable.columns.createSystemColumn(), EntityTable.columns.createOwnerColumn(), - EntityTable.columns.createSpecLifecycleColumn(), createSpecApiTypeColumn(), + EntityTable.columns.createSpecLifecycleColumn(), EntityTable.columns.createMetadataDescriptionColumn(), ]; diff --git a/plugins/catalog-react/src/components/EntityTable/columns.tsx b/plugins/catalog-react/src/components/EntityTable/columns.tsx index 27bf8854b6..6956d6a900 100644 --- a/plugins/catalog-react/src/components/EntityTable/columns.tsx +++ b/plugins/catalog-react/src/components/EntityTable/columns.tsx @@ -143,6 +143,7 @@ export function createMetadataDescriptionColumn< ), width: 'auto', From cc464a56b3156a78bfca73adfec1b03c09cd5cab Mon Sep 17 00:00:00 2001 From: Aj-vrod Date: Thu, 16 Sep 2021 16:03:22 +0200 Subject: [PATCH 2/2] add changeset Signed-off-by: Aj-vrod --- .changeset/smooth-experts-hunt.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/smooth-experts-hunt.md diff --git a/.changeset/smooth-experts-hunt.md b/.changeset/smooth-experts-hunt.md new file mode 100644 index 0000000000..8fc4be206c --- /dev/null +++ b/.changeset/smooth-experts-hunt.md @@ -0,0 +1,6 @@ +--- +'@backstage/plugin-api-docs': patch +'@backstage/plugin-catalog-react': patch +--- + +This makes Type and Lifecycle columns consistent for all table cases and adds a new line in Description column for better readability