paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 44 Packages Projects Releases Wiki Activity

Merge pull request #9879 from backstage/rugvip/dompatch

Browse Source 
cli: install both v16 and v17 of @hot-loader/react-dom
This commit is contained in:
Patrik Oldsberg
2022-03-02 09:05:59 +01:00
committed by GitHub
parent 1dbd30f00f 46a19c599f
commit d9e9b23576
4 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/package.json
+2 -1
View File
@@ -37,7 +37,8 @@
"@backstage/errors": "^0.2.2",
"@backstage/release-manifests": "^0.0.2",
"@backstage/types": "^0.1.3",
"@hot-loader/react-dom": "^17.0.2",
"@hot-loader/react-dom-v16": "npm:@hot-loader/react-dom@^16.0.2",
"@hot-loader/react-dom-v17": "npm:@hot-loader/react-dom@^17.0.2",
"@manypkg/get-packages": "^1.1.3",
"@octokit/request": "^5.4.12",
"@rollup/plugin-commonjs": "^21.0.1",
packages/cli/src/lib/bundler/config.ts
+5 -2
View File
@@ -167,13 +167,16 @@ export async function createConfig(
}),
);
// Detect and use the appropriate react-dom hot-loader patch based on what
// version of React is used within the target repo.
const resolveAliases: Record<string, string> = {};
try {
// eslint-disable-next-line import/no-extraneous-dependencies
const { version: reactDomVersion } = require('react-dom/package.json');
// Only apply the alias for hook support if we're running with React 16
if (reactDomVersion.startsWith('16.')) {
resolveAliases['react-dom'] = '@hot-loader/react-dom';
resolveAliases['react-dom'] = '@hot-loader/react-dom-v16';
} else {
resolveAliases['react-dom'] = '@hot-loader/react-dom-v17';
}
} catch (error) {
console.warn(`WARNING: Failed to read react-dom version, ${error}`);