From d98604b667b561d2c7f5b15456a549137158e291 Mon Sep 17 00:00:00 2001 From: Carlos Esteban Lopez Jaramillo Date: Thu, 4 Jan 2024 15:33:19 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Jamie Klassen Signed-off-by: Carlos Esteban Lopez Jaramillo --- plugins/kubernetes-react/config.d.ts | 2 +- .../src/hooks/useIsPodExecTerminalEnabled.test.tsx | 2 +- .../kubernetes-react/src/hooks/useIsPodExecTerminalEnabled.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/kubernetes-react/config.d.ts b/plugins/kubernetes-react/config.d.ts index d8f6ba8ca9..2d2b790d05 100644 --- a/plugins/kubernetes-react/config.d.ts +++ b/plugins/kubernetes-react/config.d.ts @@ -25,7 +25,7 @@ export interface Config { * Enable `PodExecTerminal` UI feature * @visibility frontend */ - enable?: boolean; + enabled?: boolean; }; }; } diff --git a/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalEnabled.test.tsx b/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalEnabled.test.tsx index 3faf81d9ae..84e75ce529 100644 --- a/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalEnabled.test.tsx +++ b/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalEnabled.test.tsx @@ -32,7 +32,7 @@ describe('useIsPodExecTerminalEnabled', () => { configApiRef, new ConfigReader({ kubernetes: { - podExecTerminal: { enable: isPodExecTerminalEnabled }, + podExecTerminal: { enabled: isPodExecTerminalEnabled }, }, }), ], diff --git a/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalEnabled.ts b/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalEnabled.ts index 683b9b9a5a..7598e1c570 100644 --- a/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalEnabled.ts +++ b/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalEnabled.ts @@ -23,5 +23,5 @@ import { configApiRef, useApi } from '@backstage/core-plugin-api'; export const useIsPodExecTerminalEnabled = (): boolean | undefined => { const configApi = useApi(configApiRef); - return configApi.getOptionalBoolean('kubernetes.podExecTerminal.enable'); + return configApi.getOptionalBoolean('kubernetes.podExecTerminal.enabled'); };