From d8c26d5e6df8a2b9dc2c585c746ed44f25d84c93 Mon Sep 17 00:00:00 2001
From: Camila Belo <camilaibs@gmail.com>
Date: Mon, 18 Mar 2024 18:09:16 +0100
Subject: [PATCH] refactor: apply review suggestions

Signed-off-by: Camila Belo <camilaibs@gmail.com>
---
 .../httpRouter/createCredentialsBarrier.ts                | 8 ++++----
 .../implementations/httpRouter/rateLimitStore.test.ts     | 2 +-
 .../services/implementations/httpRouter/rateLimitStore.ts | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/packages/backend-app-api/src/services/implementations/httpRouter/createCredentialsBarrier.ts b/packages/backend-app-api/src/services/implementations/httpRouter/createCredentialsBarrier.ts
index 72b93220ee..16e0203155 100644
--- a/packages/backend-app-api/src/services/implementations/httpRouter/createCredentialsBarrier.ts
+++ b/packages/backend-app-api/src/services/implementations/httpRouter/createCredentialsBarrier.ts
@@ -65,17 +65,17 @@ export function createCredentialsBarrier(options: {
   const unauthenticatedPredicates = new Array<(path: string) => boolean>();
   const cookiePredicates = new Array<(path: string) => boolean>();
 
-  // Default rate limit is 100 requests per 15 minutes
+  // Default rate limit is 60 requests per 1 minute
   const max = config?.has('backend.auth.rateLimit.max')
     ? config.getNumber('backend.auth.rateLimit.max')
-    : 100;
+    : 60;
 
   const duration = config?.has('backend.auth.rateLimit.window')
     ? readDurationFromConfig(config.getConfig('backend.auth.rateLimit.window'))
     : undefined;
 
-  // Default rate limit window is 15 minutes
-  const windowMs = duration ? durationToMilliseconds(duration) : 15 * 60 * 1000;
+  // Default rate limit window is 1 minute
+  const windowMs = duration ? durationToMilliseconds(duration) : 1 * 60 * 1000;
 
   const limiter = rateLimit({
     windowMs,
diff --git a/packages/backend-app-api/src/services/implementations/httpRouter/rateLimitStore.test.ts b/packages/backend-app-api/src/services/implementations/httpRouter/rateLimitStore.test.ts
index 843cb83ed1..44035fc62e 100644
--- a/packages/backend-app-api/src/services/implementations/httpRouter/rateLimitStore.test.ts
+++ b/packages/backend-app-api/src/services/implementations/httpRouter/rateLimitStore.test.ts
@@ -34,7 +34,7 @@ describe('RateLimitStore', () => {
   });
 
   it('should initialize with default options', () => {
-    expect(rateLimitStore.windowMs).toBe(15 * 60 * 1000);
+    expect(rateLimitStore.windowMs).toBe(1 * 60 * 1000);
   });
 
   it('should initialize with custom options', () => {
diff --git a/packages/backend-app-api/src/services/implementations/httpRouter/rateLimitStore.ts b/packages/backend-app-api/src/services/implementations/httpRouter/rateLimitStore.ts
index c111fbc2d2..423a1012a9 100644
--- a/packages/backend-app-api/src/services/implementations/httpRouter/rateLimitStore.ts
+++ b/packages/backend-app-api/src/services/implementations/httpRouter/rateLimitStore.ts
@@ -44,9 +44,9 @@ type CacheStoreValue = {
 export class RateLimitStore implements Store {
   /**
    * The duration of time before which all hit counts are reset (in milliseconds).
-   * default: 15 minutes
+   * default: 60 requests per minute
    */
-  windowMs: number = 15 * 60 * 1000;
+  windowMs: number = 1 * 60 * 1000;
   prefix: string;
   #cache: CacheService;