From d844ec8a0be4c6d67c06110f18e12b11f503c594 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Wed, 18 Oct 2023 12:52:17 +0200
Subject: [PATCH] frontend-app-api: add tests for instantiateAppNodeTree

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .../graph/instantiateAppNodeTree.test.ts      | 123 +++++++++++++++++-
 1 file changed, 122 insertions(+), 1 deletion(-)

diff --git a/packages/frontend-app-api/src/wiring/graph/instantiateAppNodeTree.test.ts b/packages/frontend-app-api/src/wiring/graph/instantiateAppNodeTree.test.ts
index ddd842c6c0..43aad4f9ae 100644
--- a/packages/frontend-app-api/src/wiring/graph/instantiateAppNodeTree.test.ts
+++ b/packages/frontend-app-api/src/wiring/graph/instantiateAppNodeTree.test.ts
@@ -21,8 +21,12 @@ import {
   createExtensionInput,
   createSchemaFromZod,
 } from '@backstage/frontend-plugin-api';
-import { createAppNodeInstance } from './instantiateAppNodeTree';
+import {
+  createAppNodeInstance,
+  instantiateAppNodeTree,
+} from './instantiateAppNodeTree';
 import { AppNodeInstance, AppNodeSpec } from './types';
+import { buildAppGraph } from './buildAppGraph';
 
 const testDataRef = createExtensionDataRef<string>('test');
 const otherDataRef = createExtensionDataRef<number>('other');
@@ -73,6 +77,123 @@ function makeInstanceWithId<TConfig>(
   };
 }
 
+describe('instantiateAppNodeTree', () => {
+  it('should instantiate a single node', () => {
+    const graph = buildAppGraph(
+      [{ ...makeSpec(simpleExtension), id: 'root-node' }],
+      'root-node',
+    );
+    expect(graph.root.instance).not.toBeDefined();
+    instantiateAppNodeTree(graph.root);
+    expect(graph.root.instance).toBeDefined();
+    expect(graph.root.instance?.getData(testDataRef)).toBe('test');
+
+    // Multiple calls should have no effect
+    instantiateAppNodeTree(graph.root);
+    expect(graph.root.instance).toBeDefined();
+  });
+
+  it('should not instantiate disabled nodes', () => {
+    const graph = buildAppGraph(
+      [{ ...makeSpec(simpleExtension), id: 'root-node', disabled: true }],
+      'root-node',
+    );
+    expect(graph.root.instance).not.toBeDefined();
+    instantiateAppNodeTree(graph.root);
+    expect(graph.root.instance).not.toBeDefined();
+  });
+
+  it('should instantiate a node with attachments', () => {
+    const graph = buildAppGraph(
+      [
+        {
+          ...makeSpec(
+            createExtension({
+              id: 'root-node',
+              attachTo: { id: 'ignored', input: 'ignored' },
+              inputs: {
+                test: createExtensionInput({ test: testDataRef }),
+              },
+              output: {
+                inputMirror: inputMirrorDataRef,
+              },
+              factory({ bind, inputs }) {
+                bind({ inputMirror: inputs });
+              },
+            }),
+          ),
+        },
+        {
+          ...makeSpec(simpleExtension),
+          id: 'child-node',
+          attachTo: { id: 'root-node', input: 'test' },
+        },
+      ],
+      'root-node',
+    );
+
+    const childNode = graph.nodes.get('child-node');
+    expect(childNode).toBeDefined();
+
+    expect(graph.root.instance).not.toBeDefined();
+    expect(childNode?.instance).not.toBeDefined();
+    instantiateAppNodeTree(graph.root);
+    expect(graph.root.instance).toBeDefined();
+    expect(childNode?.instance).toBeDefined();
+    expect(graph.root.instance?.getData(inputMirrorDataRef)).toEqual({
+      test: [{ test: 'test' }],
+    });
+
+    // Multiple calls should have no effect
+    instantiateAppNodeTree(graph.root);
+    expect(graph.root.instance).toBeDefined();
+    expect(childNode?.instance).toBeDefined();
+  });
+
+  it('should not instantiate disabled attachments', () => {
+    const graph = buildAppGraph(
+      [
+        {
+          ...makeSpec(
+            createExtension({
+              id: 'root-node',
+              attachTo: { id: 'ignored', input: 'ignored' },
+              inputs: {
+                test: createExtensionInput({ test: testDataRef }),
+              },
+              output: {
+                inputMirror: inputMirrorDataRef,
+              },
+              factory({ bind, inputs }) {
+                bind({ inputMirror: inputs });
+              },
+            }),
+          ),
+        },
+        {
+          ...makeSpec(simpleExtension),
+          id: 'child-node',
+          attachTo: { id: 'root-node', input: 'test' },
+          disabled: true,
+        },
+      ],
+      'root-node',
+    );
+
+    const childNode = graph.nodes.get('child-node');
+    expect(childNode).toBeDefined();
+
+    expect(graph.root.instance).not.toBeDefined();
+    expect(childNode?.instance).not.toBeDefined();
+    instantiateAppNodeTree(graph.root);
+    expect(graph.root.instance).toBeDefined();
+    expect(childNode?.instance).not.toBeDefined();
+    expect(graph.root.instance?.getData(inputMirrorDataRef)).toEqual({
+      test: [],
+    });
+  });
+});
+
 describe('createAppNodeInstance', () => {
   it('should create a simple extension instance', () => {
     const attachments = new Map();