frontend-app-api: follow up phased app review feedback

Fix utility API resolution for falsy values and clarify how phased app finalization is owned between onFinalized and finalize.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor

packages/frontend-app-api/src/wiring/FrontendApiRegistry.test.ts

@@ -0,0 +1,72 @@
+/*
+ * Copyright 2026 The Backstage Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {
+  type AnyApiFactory,
+  createApiRef,
+} from '@backstage/frontend-plugin-api';
+import {
+  FrontendApiRegistry,
+  FrontendApiResolver,
+} from './FrontendApiRegistry';
+
+describe('FrontendApiResolver', () => {
+  it('should cache falsy API values', () => {
+    const falseApiRef = createApiRef<boolean>({ id: 'test.false' });
+    const falseFactoryFn = jest.fn(() => false);
+    const registry = new FrontendApiRegistry();
+
+    registry.register({
+      api: falseApiRef,
+      deps: {},
+      factory: falseFactoryFn,
+    } as AnyApiFactory);
+
+    const resolver = new FrontendApiResolver({ primaryRegistry: registry });
+
+    expect(resolver.get(falseApiRef)).toBe(false);
+    expect(resolver.get(falseApiRef)).toBe(false);
+    expect(falseFactoryFn).toHaveBeenCalledTimes(1);
+  });
+
+  it('should resolve falsy dependencies', () => {
+    const falseApiRef = createApiRef<boolean>({ id: 'test.false' });
+    const dependentApiRef = createApiRef<string>({ id: 'test.dependent' });
+    const falseFactoryFn = jest.fn(() => false);
+    const dependentFactoryFn = jest.fn((deps: { falseDependency: boolean }) =>
+      deps.falseDependency === false ? 'resolved' : 'unexpected',
+    );
+    const registry = new FrontendApiRegistry();
+
+    registry.register({
+      api: falseApiRef,
+      deps: {},
+      factory: falseFactoryFn,
+    } as AnyApiFactory);
+    registry.register({
+      api: dependentApiRef,
+      deps: { falseDependency: falseApiRef },
+      factory: dependentFactoryFn,
+    } as AnyApiFactory);
+
+    const resolver = new FrontendApiResolver({ primaryRegistry: registry });
+
+    expect(resolver.get(dependentApiRef)).toBe('resolved');
+    expect(dependentFactoryFn).toHaveBeenCalledWith({
+      falseDependency: false,
+    });
+  });
+});

packages/frontend-app-api/src/wiring/FrontendApiRegistry.ts

@@ -107,7 +107,7 @@ export class FrontendApiResolver implements ApiHolder {
 
   private load<T>(ref: ApiRef<T>, loading: AnyApiRef[] = []): T | undefined {
     const existing = this.apis.get(ref.id);
-    if (existing) {
+    if (this.apis.has(ref.id)) {
       return existing as T;
     }
 
@@ -124,7 +124,7 @@ export class FrontendApiResolver implements ApiHolder {
     const deps = {} as { [name: string]: unknown };
     for (const [key, depRef] of Object.entries(factory.deps)) {
       const dep = this.load(depRef, [...loading, factory.api]);
-      if (!dep) {
+      if (dep === undefined) {
         throw new Error(
           `No API factory available for dependency ${depRef} of dependent ${factory.api}`,
         );