diff --git a/.changeset/serious-penguins-remain.md b/.changeset/serious-penguins-remain.md new file mode 100644 index 0000000000..fc90b4ad01 --- /dev/null +++ b/.changeset/serious-penguins-remain.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-catalog': minor +--- + +Allow `OffsetPaginatedCatalogTable` to configure Table options and `CursorPaginatedCatalogTable` to configure `paginationPosition`. diff --git a/plugins/catalog/src/components/CatalogTable/CursorPaginatedCatalogTable.tsx b/plugins/catalog/src/components/CatalogTable/CursorPaginatedCatalogTable.tsx index da9f13e85c..7198f8a60c 100644 --- a/plugins/catalog/src/components/CatalogTable/CursorPaginatedCatalogTable.tsx +++ b/plugins/catalog/src/components/CatalogTable/CursorPaginatedCatalogTable.tsx @@ -39,9 +39,9 @@ export function CursorPaginatedCatalogTable(props: PaginatedCatalogTableProps) { columns={columns} data={data} options={{ + paginationPosition: 'both', ...options, // These settings are configured to force server side pagination - paginationPosition: 'both', pageSizeOptions: [], showFirstLastPageButtons: false, pageSize: Number.MAX_SAFE_INTEGER, diff --git a/plugins/catalog/src/components/CatalogTable/OffsetPaginatedCatalogTable.tsx b/plugins/catalog/src/components/CatalogTable/OffsetPaginatedCatalogTable.tsx index 0faa0043a1..a86dd60b50 100644 --- a/plugins/catalog/src/components/CatalogTable/OffsetPaginatedCatalogTable.tsx +++ b/plugins/catalog/src/components/CatalogTable/OffsetPaginatedCatalogTable.tsx @@ -29,7 +29,7 @@ import { export function OffsetPaginatedCatalogTable( props: TableProps, ) { - const { columns, data, isLoading } = props; + const { columns, data, isLoading, options } = props; const { updateFilters, setLimit, setOffset, limit, totalItems, offset } = useEntityList(); const [page, setPage] = React.useState( @@ -53,6 +53,7 @@ export function OffsetPaginatedCatalogTable( pageSizeOptions: [5, 10, 20, 50, 100], pageSize: limit, emptyRowsWhenPaging: false, + ...options, }} onSearchChange={(searchText: string) => updateFilters({