chore: change most of plugins to use LoggerService

quite a big PR for this but the changes are pretty stright forward.
hopefully gets merged before most of these plugins move to the community
repository.

Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
This commit is contained in:
Heikki Hellgren
2024-04-13 01:35:47 +03:00
parent 16ef9e59e5
commit d5a1fe189b
285 changed files with 975 additions and 1050 deletions
+2 -2
View File
@@ -8,7 +8,7 @@ import { CatalogApi } from '@backstage/catalog-client';
import { CompoundEntityRef } from '@backstage/catalog-model';
import { Config } from '@backstage/config';
import express from 'express';
import { Logger } from 'winston';
import { LoggerService } from '@backstage/backend-plugin-api';
import { ScmIntegrations } from '@backstage/integration';
import { ServiceRef } from '@backstage/backend-plugin-api';
import { UrlReader } from '@backstage/backend-common';
@@ -136,7 +136,7 @@ export class TodoScmReader implements TodoReader {
// @public (undocumented)
export type TodoScmReaderOptions = {
logger: Logger;
logger: LoggerService;
reader: UrlReader;
integrations: ScmIntegrations;
parser?: TodoParser;
-1
View File
@@ -46,7 +46,6 @@
"@types/express": "^4.17.6",
"express": "^4.17.1",
"leasot": "^12.0.0",
"winston": "^3.2.1",
"yn": "^4.0.0"
},
"devDependencies": {
@@ -14,9 +14,8 @@
* limitations under the License.
*/
import { loggerToWinstonLogger, UrlReader } from '@backstage/backend-common';
import { UrlReader } from '@backstage/backend-common';
import { ScmIntegrations } from '@backstage/integration';
import { Logger } from 'winston';
import {
ReadTodosOptions,
@@ -32,6 +31,7 @@ import {
coreServices,
createServiceFactory,
createServiceRef,
LoggerService,
} from '@backstage/backend-plugin-api';
const excludedExtensions = [
@@ -48,7 +48,7 @@ const MAX_FILE_SIZE = 200000;
/** @public */
export type TodoScmReaderOptions = {
logger: Logger;
logger: LoggerService;
reader: UrlReader;
integrations: ScmIntegrations;
parser?: TodoParser;
@@ -62,7 +62,7 @@ type CacheItem = {
/** @public */
export class TodoScmReader implements TodoReader {
private readonly logger: Logger;
private readonly logger: LoggerService;
private readonly reader: UrlReader;
private readonly parser: TodoParser;
private readonly integrations: ScmIntegrations;
@@ -187,9 +187,8 @@ export const todoReaderServiceRef = createServiceRef<TodoReader>({
logger: coreServices.logger,
},
factory: async ({ reader, config, logger }) => {
const winstonLogger = loggerToWinstonLogger(logger);
return TodoScmReader.fromConfig(config, {
logger: winstonLogger,
logger,
reader,
});
},