From d4e33aca1adc461063130fa36e255498490785ec Mon Sep 17 00:00:00 2001 From: blam Date: Tue, 23 Jul 2024 08:19:53 +0200 Subject: [PATCH] chore: fixing tests Signed-off-by: blam --- .../src/components/TabbedLayout/RoutedTabs.test.tsx | 5 +++-- .../src/components/TabbedLayout/RoutedTabs.tsx | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/core-components/src/components/TabbedLayout/RoutedTabs.test.tsx b/packages/core-components/src/components/TabbedLayout/RoutedTabs.test.tsx index 991276c5d3..754ac2ec8d 100644 --- a/packages/core-components/src/components/TabbedLayout/RoutedTabs.test.tsx +++ b/packages/core-components/src/components/TabbedLayout/RoutedTabs.test.tsx @@ -162,14 +162,15 @@ describe('RoutedTabs', () => { }); it('should render the tabs as links', async () => { - const routes = [testRoute2, testRoute1, testRoute3]; + const routes = [testRoute1, testRoute2, testRoute3]; + const expectedHrefs = ['/', '/some-other-path', '/some-other-path-similar']; const rendered = await renderInTestApp(); const tabs = rendered.queryAllByRole('tab'); for (const [k, v] of Object.entries(tabs)) { expect(v.tagName).toBe('A'); - expect(v).toHaveAttribute('href', routes[Number(k)].path); + expect(v).toHaveAttribute('href', expectedHrefs[Number(k)]); } }); }); diff --git a/packages/core-components/src/components/TabbedLayout/RoutedTabs.tsx b/packages/core-components/src/components/TabbedLayout/RoutedTabs.tsx index d6f6eab144..b57a3782bb 100644 --- a/packages/core-components/src/components/TabbedLayout/RoutedTabs.tsx +++ b/packages/core-components/src/components/TabbedLayout/RoutedTabs.tsx @@ -79,9 +79,9 @@ export function RoutedTabs(props: { routes: SubRoute[] }) { id: path, label: title, tabProps: { - ...tabProps, component: Link, to, + ...tabProps, }, }; }),