From bd58c7048544b598ee0accdc97ddf2dc4238bc1c Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Sat, 29 Apr 2023 13:53:05 -0400 Subject: [PATCH 1/4] fix: Typos in test descriptions Signed-off-by: Adam Harvey --- .../src/next/services/MockRootLoggerService.test.ts | 10 +++++----- packages/test-utils/src/testUtils/logCollector.test.ts | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/backend-test-utils/src/next/services/MockRootLoggerService.test.ts b/packages/backend-test-utils/src/next/services/MockRootLoggerService.test.ts index a3cbb5c384..007b24faeb 100644 --- a/packages/backend-test-utils/src/next/services/MockRootLoggerService.test.ts +++ b/packages/backend-test-utils/src/next/services/MockRootLoggerService.test.ts @@ -39,7 +39,7 @@ describe('MockRootLoggerService', () => { expect(console.debug).not.toHaveBeenCalled(); }); - it('shuld be able to set none level', () => { + it('should be able to set none level', () => { jest.spyOn(console, 'error').mockImplementation(() => {}); jest.spyOn(console, 'warn').mockImplementation(() => {}); jest.spyOn(console, 'info').mockImplementation(() => {}); @@ -57,7 +57,7 @@ describe('MockRootLoggerService', () => { expect(console.debug).not.toHaveBeenCalled(); }); - it('shuld be able to set error level', () => { + it('should be able to set error level', () => { jest.spyOn(console, 'error').mockImplementation(() => {}); jest.spyOn(console, 'warn').mockImplementation(() => {}); jest.spyOn(console, 'info').mockImplementation(() => {}); @@ -75,7 +75,7 @@ describe('MockRootLoggerService', () => { expect(console.debug).not.toHaveBeenCalled(); }); - it('shuld be able to set warn level', () => { + it('should be able to set warn level', () => { jest.spyOn(console, 'error').mockImplementation(() => {}); jest.spyOn(console, 'warn').mockImplementation(() => {}); jest.spyOn(console, 'info').mockImplementation(() => {}); @@ -93,7 +93,7 @@ describe('MockRootLoggerService', () => { expect(console.debug).not.toHaveBeenCalled(); }); - it('shuld be able to set info level', () => { + it('should be able to set info level', () => { jest.spyOn(console, 'error').mockImplementation(() => {}); jest.spyOn(console, 'warn').mockImplementation(() => {}); jest.spyOn(console, 'info').mockImplementation(() => {}); @@ -111,7 +111,7 @@ describe('MockRootLoggerService', () => { expect(console.debug).not.toHaveBeenCalled(); }); - it('shuld be able to set debug level', () => { + it('should be able to set debug level', () => { jest.spyOn(console, 'error').mockImplementation(() => {}); jest.spyOn(console, 'warn').mockImplementation(() => {}); jest.spyOn(console, 'info').mockImplementation(() => {}); diff --git a/packages/test-utils/src/testUtils/logCollector.test.ts b/packages/test-utils/src/testUtils/logCollector.test.ts index fc66d7a26e..b217aaad8c 100644 --- a/packages/test-utils/src/testUtils/logCollector.test.ts +++ b/packages/test-utils/src/testUtils/logCollector.test.ts @@ -34,7 +34,7 @@ describe('logCollector', () => { expect(logs.error).toEqual(['c', '3']); }); - it('should collect some logs asynchrnously', async () => { + it('should collect some logs asynchronously', async () => { const logs = await withLogCollector(async () => { console.log('a'); console.warn('b'); @@ -70,7 +70,7 @@ describe('logCollector', () => { expect(missedLogs.error).toEqual(['c', '3']); }); - it('should collect specific logs asynchrnously', async () => { + it('should collect specific logs asynchronously', async () => { const missedLogs = await withLogCollector(async () => { const logs = await withLogCollector(['error'], async () => { console.log('a'); From 23e45c47d09c5b3c25cf68d070a292c25fa4f4df Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Sat, 29 Apr 2023 13:53:35 -0400 Subject: [PATCH 2/4] fix: Comment typos Signed-off-by: Adam Harvey --- .../src/scaffolder/actions/builtin/fetch/template.ts | 2 +- .../src/service/fact/FactRetrieverEngine.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/template.ts b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/template.ts index 7659cff240..1f80f92334 100644 --- a/plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/template.ts +++ b/plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/template.ts @@ -324,7 +324,7 @@ function containsSkippedContent(localOutputPath: string): boolean { // if the path is empty means that there is a file skipped in the root // if the path starts with a separator it means that the root directory has been skipped // if the path includes // means that there is a subdirectory skipped - // All paths returned are considered with / seperator because of globby returning the linux seperator for all os'. + // All paths returned are considered with / separator because of globby returning the linux separator for all os'. return ( localOutputPath === '' || localOutputPath.startsWith('/') || diff --git a/plugins/tech-insights-backend/src/service/fact/FactRetrieverEngine.ts b/plugins/tech-insights-backend/src/service/fact/FactRetrieverEngine.ts index e223604829..846871db88 100644 --- a/plugins/tech-insights-backend/src/service/fact/FactRetrieverEngine.ts +++ b/plugins/tech-insights-backend/src/service/fact/FactRetrieverEngine.ts @@ -48,7 +48,7 @@ export interface FactRetrieverEngine { * Schedules fact retriever run cycles based on configuration provided in the registration. * * Default implementation uses backend-tasks to handle scheduling. This function can be called multiple - * times, where initial calls schedule the tasks and subsequents invocations update the schedules. + * times, where initial calls schedule the tasks and subsequent invocations update the schedules. */ schedule(): Promise; From 87a0b37aa73d6b1f6efbc8df2ba9a6286b72c919 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Sat, 29 Apr 2023 13:58:49 -0400 Subject: [PATCH 3/4] refactor: Variable typo Signed-off-by: Adam Harvey --- .../techdocs-node/src/stages/publish/azureBlobStorage.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/techdocs-node/src/stages/publish/azureBlobStorage.test.ts b/plugins/techdocs-node/src/stages/publish/azureBlobStorage.test.ts index a392d3c172..01565aa2df 100644 --- a/plugins/techdocs-node/src/stages/publish/azureBlobStorage.test.ts +++ b/plugins/techdocs-node/src/stages/publish/azureBlobStorage.test.ts @@ -506,7 +506,7 @@ describe('AzureBlobStoragePublish', () => { name: 'path', }; - const techDocsMetadaFilePath = path.posix.join( + const techDocsMetadataFilePath = path.posix.join( ...Object.values(invalidEntityName), 'techdocs_metadata.json', ); @@ -514,7 +514,7 @@ describe('AzureBlobStoragePublish', () => { const fails = publisher.fetchTechDocsMetadata(invalidEntityName); await expect(fails).rejects.toMatchObject({ - message: `TechDocs metadata fetch failed; caused by Error: The file ${techDocsMetadaFilePath} does not exist!`, + message: `TechDocs metadata fetch failed; caused by Error: The file ${techDocsMetadataFilePath} does not exist!`, }); }); }); From 38235817a32f0df8b6713ae168395e8898e6f101 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Sat, 29 Apr 2023 14:00:35 -0400 Subject: [PATCH 4/4] fix: Comment typos Signed-off-by: Adam Harvey --- .../src/actions/confluence/confluenceToMarkdown.test.ts | 2 +- .../src/actions/confluence/confluenceToMarkdown.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/scaffolder-backend-module-confluence-to-markdown/src/actions/confluence/confluenceToMarkdown.test.ts b/plugins/scaffolder-backend-module-confluence-to-markdown/src/actions/confluence/confluenceToMarkdown.test.ts index 67f98d5fea..136bfc521e 100644 --- a/plugins/scaffolder-backend-module-confluence-to-markdown/src/actions/confluence/confluenceToMarkdown.test.ts +++ b/plugins/scaffolder-backend-module-confluence-to-markdown/src/actions/confluence/confluenceToMarkdown.test.ts @@ -209,7 +209,7 @@ describe('confluence:transform:markdown', () => { expect(writeFile).toHaveBeenCalledTimes(1); }); - it('shoud fail on the first fetch call with response.ok set to false', async () => { + it('should fail on the first fetch call with response.ok set to false', async () => { const options = { reader, integrations, diff --git a/plugins/scaffolder-backend-module-confluence-to-markdown/src/actions/confluence/confluenceToMarkdown.ts b/plugins/scaffolder-backend-module-confluence-to-markdown/src/actions/confluence/confluenceToMarkdown.ts index 655b1bbdb7..801f8abb28 100644 --- a/plugins/scaffolder-backend-module-confluence-to-markdown/src/actions/confluence/confluenceToMarkdown.ts +++ b/plugins/scaffolder-backend-module-confluence-to-markdown/src/actions/confluence/confluenceToMarkdown.ts @@ -107,7 +107,7 @@ export const createConfluenceToMarkdownAction = (options: { `Could not find document ${url}. Please check your input.`, ); } - // This gets attachements for the confluence page if they exist + // This gets attachments for the confluence page if they exist const getDocAttachments = await fetchConfluence( `/rest/api/content/${getConfluenceDoc.results[0].id}/child/attachment`, config,