diff --git a/.changeset/thin-candles-wait.md b/.changeset/thin-candles-wait.md new file mode 100644 index 0000000000..c7e18367b5 --- /dev/null +++ b/.changeset/thin-candles-wait.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-sonarqube': patch +--- + +Show a more appropriate icon if there are no code smells and/or vulnerabilities. diff --git a/plugins/sonarqube/src/components/SonarQubeCard/SonarQubeCard.tsx b/plugins/sonarqube/src/components/SonarQubeCard/SonarQubeCard.tsx index 900c8d082c..f37bd6eda5 100644 --- a/plugins/sonarqube/src/components/SonarQubeCard/SonarQubeCard.tsx +++ b/plugins/sonarqube/src/components/SonarQubeCard/SonarQubeCard.tsx @@ -23,9 +23,11 @@ import { import { Chip, Grid } from '@material-ui/core'; import { makeStyles } from '@material-ui/core/styles'; import BugReport from '@material-ui/icons/BugReport'; +import Lock from '@material-ui/icons/Lock'; import LockOpen from '@material-ui/icons/LockOpen'; import Security from '@material-ui/icons/Security'; import SentimentVeryDissatisfied from '@material-ui/icons/SentimentVeryDissatisfied'; +import SentimentVerySatisfied from '@material-ui/icons/SentimentVerySatisfied'; import React, { useMemo } from 'react'; import useAsync from 'react-use/lib/useAsync'; import { Percentage } from './Percentage'; @@ -200,14 +202,22 @@ export const SonarQubeCard = (props: { rightSlot={} /> } + titleIcon={ + value.metrics.vulnerabilities === '0' ? : + } title="Vulnerabilities" link={value.getIssuesUrl('VULNERABILITY')} leftSlot={} rightSlot={} /> } + titleIcon={ + value.metrics.code_smells === '0' ? ( + + ) : ( + + ) + } title="Code Smells" link={value.getIssuesUrl('CODE_SMELL')} leftSlot={}