From d32f8282a52013874b4513e92407acfc8740372d Mon Sep 17 00:00:00 2001 From: AmbrishRamachandiran Date: Wed, 4 Mar 2026 18:14:28 +0530 Subject: [PATCH] Fix review comments Signed-off-by: AmbrishRamachandiran --- .../src/components/RangeSlider/RangeSlider.tsx | 16 ++++++++++------ .../ui/src/components/RangeSlider/definition.ts | 1 + 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/ui/src/components/RangeSlider/RangeSlider.tsx b/packages/ui/src/components/RangeSlider/RangeSlider.tsx index 731bd28c73..b6ca6a5026 100644 --- a/packages/ui/src/components/RangeSlider/RangeSlider.tsx +++ b/packages/ui/src/components/RangeSlider/RangeSlider.tsx @@ -57,10 +57,12 @@ export const RangeSlider = forwardRef( const minValue = props.minValue ?? 0; const maxValue = props.maxValue ?? 100; - const { - defaultValue = [minValue, maxValue] as [number, number], - ...propsWithoutDefault - } = props; + const uncontrolledDefaultValue = + props.value === undefined + ? ((props.defaultValue ?? + ([minValue, maxValue] as [number, number])) as [number, number]) + : undefined; + const { defaultValue: _ignoredDefault, ...propsWithoutDefault } = props; const { classNames, dataAttributes, style, cleanedProps } = useStyles( RangeSliderDefinition, @@ -68,7 +70,9 @@ export const RangeSlider = forwardRef( minValue, maxValue, step: 1, - defaultValue, + ...(uncontrolledDefaultValue !== undefined + ? { defaultValue: uncontrolledDefaultValue } + : {}), ...propsWithoutDefault, }, ); @@ -97,7 +101,7 @@ export const RangeSlider = forwardRef( {...rest} ref={ref} > -
+