From 789aa030b374823fd36e82249141dc7f80082620 Mon Sep 17 00:00:00 2001 From: Erik Sjoholm Date: Mon, 13 May 2024 16:45:51 -0700 Subject: [PATCH 1/4] fix a bug documented in issue#24753 where markdown descriptions are not being opened in a new tab Signed-off-by: Erik Sjoholm --- .../src/next/components/ScaffolderField/ScaffolderField.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/scaffolder-react/src/next/components/ScaffolderField/ScaffolderField.tsx b/plugins/scaffolder-react/src/next/components/ScaffolderField/ScaffolderField.tsx index 1bb1656fd0..60c3907ddb 100644 --- a/plugins/scaffolder-react/src/next/components/ScaffolderField/ScaffolderField.tsx +++ b/plugins/scaffolder-react/src/next/components/ScaffolderField/ScaffolderField.tsx @@ -76,6 +76,7 @@ export const ScaffolderField = ( {displayLabel && rawDescription ? ( ) : null} From 86dc29dcbe0bcd5bf225036c37ca0ed9d9268c0e Mon Sep 17 00:00:00 2001 From: Erik Sjoholm Date: Mon, 13 May 2024 16:52:00 -0700 Subject: [PATCH 2/4] Add changeset and api-report Signed-off-by: Erik Sjoholm --- .changeset/loud-pumpkins-bow.md | 5 +++++ plugins/scaffolder-backend/api-report.md | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 .changeset/loud-pumpkins-bow.md diff --git a/.changeset/loud-pumpkins-bow.md b/.changeset/loud-pumpkins-bow.md new file mode 100644 index 0000000000..366645db24 --- /dev/null +++ b/.changeset/loud-pumpkins-bow.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder-react': patch +--- + +Fixed a bug where links in scaffolder field markdown content e.g. - description was not able to be launched in a new tab. This fix makes it so that all links within Scaffolder Fields are launched in a new tab. diff --git a/plugins/scaffolder-backend/api-report.md b/plugins/scaffolder-backend/api-report.md index c141733ec4..8a9623d78f 100644 --- a/plugins/scaffolder-backend/api-report.md +++ b/plugins/scaffolder-backend/api-report.md @@ -302,7 +302,10 @@ export const createPublishGitlabMergeRequestAction: (options: { }) => TemplateAction_2< { repoUrl: string; - title: string; + title: string + /** + * @public @deprecated use import from \@backstage/plugin-scaffolder-backend-module-github instead + */; description: string; branchName: string; targetBranchName?: string | undefined; From 881e49d94c2bf54bb7007c61a7c4c75400135c49 Mon Sep 17 00:00:00 2001 From: Erik Sjoholm Date: Tue, 14 May 2024 10:33:50 -0700 Subject: [PATCH 3/4] Remove changes to scaffolder-backend api-report generated by running yarn build:api-reports Signed-off-by: Erik Sjoholm --- plugins/scaffolder-backend/api-report.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/plugins/scaffolder-backend/api-report.md b/plugins/scaffolder-backend/api-report.md index 8a9623d78f..c141733ec4 100644 --- a/plugins/scaffolder-backend/api-report.md +++ b/plugins/scaffolder-backend/api-report.md @@ -302,10 +302,7 @@ export const createPublishGitlabMergeRequestAction: (options: { }) => TemplateAction_2< { repoUrl: string; - title: string - /** - * @public @deprecated use import from \@backstage/plugin-scaffolder-backend-module-github instead - */; + title: string; description: string; branchName: string; targetBranchName?: string | undefined; From 3dca9cbe7b817bc2cc4e68f44f0a177b611a887c Mon Sep 17 00:00:00 2001 From: erik-adsk <143032411+erik-adsk@users.noreply.github.com> Date: Wed, 15 May 2024 09:55:32 -0700 Subject: [PATCH 4/4] Update .changeset description to be more succinct Co-authored-by: Ben Lambert Signed-off-by: erik-adsk <143032411+erik-adsk@users.noreply.github.com> --- .changeset/loud-pumpkins-bow.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/loud-pumpkins-bow.md b/.changeset/loud-pumpkins-bow.md index 366645db24..a55c97e19a 100644 --- a/.changeset/loud-pumpkins-bow.md +++ b/.changeset/loud-pumpkins-bow.md @@ -2,4 +2,4 @@ '@backstage/plugin-scaffolder-react': patch --- -Fixed a bug where links in scaffolder field markdown content e.g. - description was not able to be launched in a new tab. This fix makes it so that all links within Scaffolder Fields are launched in a new tab. +Links that are rendered in the markdown in the `ScaffolderField` component are now opened in new tabs.