address review comments

Signed-off-by: Kashish Mittal <kmittal@redhat.com>
This commit is contained in:
Kashish Mittal
2025-04-28 11:27:59 -04:00
parent 66f50e6a42
commit d2b8e6e461
14 changed files with 21 additions and 70 deletions
@@ -161,16 +161,6 @@ describe('OngoingTask', () => {
await expect(rendered.findByText('Hide Logs')).resolves.toBeInTheDocument();
});
it('should render not found error page when user does not have permission to read the task', async () => {
const permissionApi = mockApis.permission({
authorize: AuthorizeResult.DENY,
});
await expect(render(permissionApi)).rejects.toThrow(
'Reached NotFound Page',
);
});
it('should have cancel button be disabled when user has read permission but lacks cancel permission', async () => {
const permissionApi = mockApis.permission({
authorize: request => {
@@ -46,7 +46,7 @@ import {
TaskSteps,
} from '@backstage/plugin-scaffolder-react/alpha';
import { useAsync } from '@react-hookz/web';
import { usePermission} from '@backstage/plugin-permission-react';
import { usePermission } from '@backstage/plugin-permission-react';
import {
taskCancelPermission,
taskCreatePermission,