From 22e3f003b7b689f73f550779e112473a2f435f48 Mon Sep 17 00:00:00 2001 From: blam Date: Mon, 12 Apr 2021 13:51:57 +0200 Subject: [PATCH 1/4] chore: fix of resolutions for now for the package that's broken the build Signed-off-by: blam --- package.json | 3 ++- packages/create-app/templates/default-app/package.json.hbs | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index fcabe5b3e5..be9998ce22 100644 --- a/package.json +++ b/package.json @@ -38,7 +38,8 @@ "resolutions": { "**/@roadiehq/**/@backstage/core": "*", "**/@roadiehq/**/@backstage/plugin-catalog": "*", - "**/@roadiehq/**/@backstage/catalog-model": "*" + "**/@roadiehq/**/@backstage/catalog-model": "*", + "graphql-language-service-interface": "2.8.2" }, "version": "1.0.0", "devDependencies": { diff --git a/packages/create-app/templates/default-app/package.json.hbs b/packages/create-app/templates/default-app/package.json.hbs index d7f7fbafaf..2f1ae134bf 100644 --- a/packages/create-app/templates/default-app/package.json.hbs +++ b/packages/create-app/templates/default-app/package.json.hbs @@ -22,6 +22,9 @@ "create-plugin": "backstage-cli create-plugin --scope internal --no-private", "remove-plugin": "backstage-cli remove-plugin" }, + "resolutions": { + "graphql-language-service-interface": "2.8.2" + }, "workspaces": { "packages": [ "packages/*", From b49a525ab67a843a05ac3e7e9f70d480544fbe4d Mon Sep 17 00:00:00 2001 From: blam Date: Mon, 12 Apr 2021 14:00:52 +0200 Subject: [PATCH 2/4] chore: add changeset Signed-off-by: blam --- .changeset/fluffy-rice-push.md | 5 +++++ yarn.lock | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/fluffy-rice-push.md diff --git a/.changeset/fluffy-rice-push.md b/.changeset/fluffy-rice-push.md new file mode 100644 index 0000000000..69dd7fe4f6 --- /dev/null +++ b/.changeset/fluffy-rice-push.md @@ -0,0 +1,5 @@ +--- +'@backstage/create-app': patch +--- + +Fixing dependency resolution for problematic library graphql-language-service-interface diff --git a/yarn.lock b/yarn.lock index cf967cf96f..f4843d960e 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14492,7 +14492,7 @@ graphql-extensions@^0.12.8: apollo-server-env "^3.0.0" apollo-server-types "^0.6.3" -graphql-language-service-interface@^2.8.2: +graphql-language-service-interface@2.8.2, graphql-language-service-interface@^2.8.2: version "2.8.2" resolved "https://registry.npmjs.org/graphql-language-service-interface/-/graphql-language-service-interface-2.8.2.tgz#b3bb2aef7eaf0dff0b4ea419fa412c5f66fa268b" integrity sha512-otbOQmhgkAJU1QJgQkMztNku6SbJLu/uodoFOYOOtJsizTjrMs93vkYaHCcYnLA3oi1Goj27XcHjMnRCYQOZXQ== From a4c85bd0e31489712f3914d6a4d9ba6cabc54add Mon Sep 17 00:00:00 2001 From: blam Date: Mon, 12 Apr 2021 14:04:45 +0200 Subject: [PATCH 3/4] chore: update changeset description Signed-off-by: blam --- .changeset/fluffy-rice-push.md | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/.changeset/fluffy-rice-push.md b/.changeset/fluffy-rice-push.md index 69dd7fe4f6..dc56db4678 100644 --- a/.changeset/fluffy-rice-push.md +++ b/.changeset/fluffy-rice-push.md @@ -2,4 +2,28 @@ '@backstage/create-app': patch --- -Fixing dependency resolution for problematic library graphql-language-service-interface +Fixing dependency resolution for problematic library `graphql-language-service-interface`. + +This change might not have to be applied to your local installation, however if you run into this error: + +``` +Error: Failed to compile. +/tmp/backstage-e2e-uMeycm/test-app/node_modules/graphql-language-service-interface/esm/GraphQLLanguageService.js 100:23 +Module parse failed: Unexpected token (100:23) +You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders +| } +| let customRules = null; +> if (extensions?.customValidationRules && +| typeof extensions.customValidationRules === 'function') { +| customRules = extensions.customValidationRules(this._graphQLConfig); +``` + +You can fix it by adding the following to the root `package.json`. + +```json +... +"resolutions": { + "graphql-language-service-interface": "2.8.2" + }, +... +``` From 02e9f013044cf4f3a6913aba4b56b8f1c3102956 Mon Sep 17 00:00:00 2001 From: blam Date: Mon, 12 Apr 2021 14:41:07 +0200 Subject: [PATCH 4/4] chore: was missing one other dependency Signed-off-by: blam --- .changeset/fluffy-rice-push.md | 3 ++- package.json | 3 ++- packages/create-app/templates/default-app/package.json.hbs | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.changeset/fluffy-rice-push.md b/.changeset/fluffy-rice-push.md index dc56db4678..032d580c6b 100644 --- a/.changeset/fluffy-rice-push.md +++ b/.changeset/fluffy-rice-push.md @@ -23,7 +23,8 @@ You can fix it by adding the following to the root `package.json`. ```json ... "resolutions": { - "graphql-language-service-interface": "2.8.2" + "graphql-language-service-interface": "2.8.2", + "graphql-language-service-parser": "1.9.0" }, ... ``` diff --git a/package.json b/package.json index be9998ce22..d87b98fbdb 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,8 @@ "**/@roadiehq/**/@backstage/core": "*", "**/@roadiehq/**/@backstage/plugin-catalog": "*", "**/@roadiehq/**/@backstage/catalog-model": "*", - "graphql-language-service-interface": "2.8.2" + "graphql-language-service-interface": "2.8.2", + "graphql-language-service-parser": "1.9.0" }, "version": "1.0.0", "devDependencies": { diff --git a/packages/create-app/templates/default-app/package.json.hbs b/packages/create-app/templates/default-app/package.json.hbs index 2f1ae134bf..7ae86c0fbc 100644 --- a/packages/create-app/templates/default-app/package.json.hbs +++ b/packages/create-app/templates/default-app/package.json.hbs @@ -23,7 +23,8 @@ "remove-plugin": "backstage-cli remove-plugin" }, "resolutions": { - "graphql-language-service-interface": "2.8.2" + "graphql-language-service-interface": "2.8.2", + "graphql-language-service-parser": "1.9.0" }, "workspaces": { "packages": [