From 3f956a154b09e554c2512397440061df2fc2cddf Mon Sep 17 00:00:00 2001 From: Peter Macdonald Date: Mon, 23 Jan 2023 13:48:28 +0100 Subject: [PATCH 1/3] Added a message under feature flag(s) to advise a page reload is needed when toggling them Signed-off-by: Peter Macdonald --- .../src/components/FeatureFlags/UserSettingsFeatureFlags.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/plugins/user-settings/src/components/FeatureFlags/UserSettingsFeatureFlags.tsx b/plugins/user-settings/src/components/FeatureFlags/UserSettingsFeatureFlags.tsx index a3b5f593ae..c086f70dd8 100644 --- a/plugins/user-settings/src/components/FeatureFlags/UserSettingsFeatureFlags.tsx +++ b/plugins/user-settings/src/components/FeatureFlags/UserSettingsFeatureFlags.tsx @@ -82,6 +82,10 @@ export const UserSettingsFeatureFlags = () => { Feature Flags + + {' '} + Please refresh the page when toggling feature flags{' '} + {featureFlags.length >= 10 && ( From 1412f0ea62632e2eb791d224a05c6af724e6ac69 Mon Sep 17 00:00:00 2001 From: Peter Macdonald Date: Mon, 23 Jan 2023 14:01:12 +0100 Subject: [PATCH 2/3] Added a message under feature flag(s) to advise a page reload is needed when toggling them Signed-off-by: Peter Macdonald --- .../src/components/FeatureFlags/UserSettingsFeatureFlags.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/plugins/user-settings/src/components/FeatureFlags/UserSettingsFeatureFlags.tsx b/plugins/user-settings/src/components/FeatureFlags/UserSettingsFeatureFlags.tsx index c086f70dd8..c58e637bd2 100644 --- a/plugins/user-settings/src/components/FeatureFlags/UserSettingsFeatureFlags.tsx +++ b/plugins/user-settings/src/components/FeatureFlags/UserSettingsFeatureFlags.tsx @@ -83,8 +83,7 @@ export const UserSettingsFeatureFlags = () => { Feature Flags - {' '} - Please refresh the page when toggling feature flags{' '} + Please refresh the page when toggling feature flags {featureFlags.length >= 10 && ( From c4940b6322668292e46b9455db194a6ba259195b Mon Sep 17 00:00:00 2001 From: Peter Macdonald Date: Mon, 23 Jan 2023 14:05:00 +0100 Subject: [PATCH 3/3] Forgot Changeset Signed-off-by: Peter Macdonald --- .changeset/rotten-mayflies-love.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/rotten-mayflies-love.md diff --git a/.changeset/rotten-mayflies-love.md b/.changeset/rotten-mayflies-love.md new file mode 100644 index 0000000000..24d4e4d1be --- /dev/null +++ b/.changeset/rotten-mayflies-love.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-user-settings': patch +--- + +Added a message to advise a page reload when toggling feature flags