From d1428a0d36a2238c0ee35c01f10c4f90fb2330b6 Mon Sep 17 00:00:00 2001 From: "Nolan, Tavi" Date: Thu, 11 Apr 2024 11:20:11 +0100 Subject: [PATCH] Update githubRepoPush.ts Signed-off-by: Nolan, Tavi --- .../src/actions/githubRepoPush.ts | 21 +++++-------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/plugins/scaffolder-backend-module-github/src/actions/githubRepoPush.ts b/plugins/scaffolder-backend-module-github/src/actions/githubRepoPush.ts index 5b10226b3d..5b9db78f48 100644 --- a/plugins/scaffolder-backend-module-github/src/actions/githubRepoPush.ts +++ b/plugins/scaffolder-backend-module-github/src/actions/githubRepoPush.ts @@ -14,22 +14,20 @@ * limitations under the License. */ -import * as inputProps from './inputProperties'; -import * as outputProps from './outputProperties'; - +import { Config } from '@backstage/config'; +import { InputError } from '@backstage/errors'; import { GithubCredentialsProvider, ScmIntegrationRegistry, } from '@backstage/integration'; +import { Octokit } from 'octokit'; import { createTemplateAction, parseRepoUrl, } from '@backstage/plugin-scaffolder-node'; import { getOctokitOptions, initRepoPushAndProtect } from './helpers'; - -import { Config } from '@backstage/config'; -import { InputError } from '@backstage/errors'; -import { Octokit } from 'octokit'; +import * as inputProps from './inputProperties'; +import * as outputProps from './outputProperties'; import { examples } from './githubRepoPush.examples'; /** @@ -158,15 +156,6 @@ export function createGithubRepoPushAction(options: { const remoteUrl = targetRepo.data.clone_url; const repoContentsUrl = `${targetRepo.data.html_url}/blob/${defaultBranch}`; - if (ctx.isDryRun) { - ctx.logger.info(`Performing dry run of creating pull request`); - ctx.output('remoteUrl', 'www.example.com'); - ctx.output('repoContentsUrl', 'www.example.com/content'); - ctx.output('commitHash', 'commitHash'); - ctx.logger.info(`Dry run complete`); - return; - } - const { commitHash } = await initRepoPushAndProtect( remoteUrl, octokitOptions.auth,