From d10f6b611102d93d6374ac39c441e4ec403bdcf4 Mon Sep 17 00:00:00 2001 From: Heikki Hellgren Date: Wed, 11 Sep 2024 09:56:30 +0300 Subject: [PATCH] feat(cli): allow overriding minify flag with build repo command Signed-off-by: Heikki Hellgren --- .changeset/wise-dodos-retire.md | 5 +++++ packages/cli/cli-report.md | 1 + packages/cli/src/commands/index.ts | 4 ++++ packages/cli/src/commands/repo/build.ts | 6 +++--- 4 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 .changeset/wise-dodos-retire.md diff --git a/.changeset/wise-dodos-retire.md b/.changeset/wise-dodos-retire.md new file mode 100644 index 0000000000..40ae83f824 --- /dev/null +++ b/.changeset/wise-dodos-retire.md @@ -0,0 +1,5 @@ +--- +'@backstage/cli': patch +--- + +Allow overriding minify flag with build repo command diff --git a/packages/cli/cli-report.md b/packages/cli/cli-report.md index 980d305c12..d77271c4b3 100644 --- a/packages/cli/cli-report.md +++ b/packages/cli/cli-report.md @@ -424,6 +424,7 @@ Usage: backstage-cli repo build [options] Options: --all --since + --minify -h, --help ``` diff --git a/packages/cli/src/commands/index.ts b/packages/cli/src/commands/index.ts index 7c3192fb2e..b1658a5ff1 100644 --- a/packages/cli/src/commands/index.ts +++ b/packages/cli/src/commands/index.ts @@ -50,6 +50,10 @@ export function registerRepoCommand(program: Command) { '--since ', 'Only build packages and their dev dependents that changed since the specified ref', ) + .option( + '--minify', + 'Minify the generated code. Does not apply to app package (app is minified by default).', + ) .action(lazy(() => import('./repo/build').then(m => m.command))); command diff --git a/packages/cli/src/commands/repo/build.ts b/packages/cli/src/commands/repo/build.ts index 6a2b9be06d..3ed528cd50 100644 --- a/packages/cli/src/commands/repo/build.ts +++ b/packages/cli/src/commands/repo/build.ts @@ -20,8 +20,8 @@ import { relative as relativePath } from 'path'; import { buildPackages, getOutputsForRole } from '../../lib/builder'; import { paths } from '../../lib/paths'; import { - PackageGraph, BackstagePackage, + PackageGraph, PackageRoles, } from '@backstage/cli-node'; import { runParallelWorkers } from '../../lib/parallel'; @@ -136,8 +136,8 @@ export async function command(opts: OptionValues, cmd: Command): Promise { packageJson: pkg.packageJson, outputs, logPrefix: `${chalk.cyan(relativePath(paths.targetRoot, pkg.dir))}: `, - minify: buildOptions.minify, workspacePackages: packages, + minify: opts.minify ?? buildOptions.minify, }; }); @@ -180,7 +180,7 @@ export async function command(opts: OptionValues, cmd: Command): Promise { await buildBackend({ targetDir: pkg.dir, skipBuildDependencies: true, - minify: buildOptions.minify, + minify: opts.minify ?? buildOptions.minify, }); }, });